From: Alexey Khoroshilov <khoroshilov-ufN2psIa012HXe+LvDLADg@public•gmane.org>
To: Christian Lamparter <chunkeey-gM/Ye1E23mwN+BqQ9rBEUg@public•gmane.org>
Cc: "John W. Linville"
<linville-2XuSBdqkA4R54TAoqtyWWQ@public•gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
ldv-project-tpLiQldItUH5n4uC9ZG1Ww@public•gmane.org
Subject: Re: [PATCH] p54pci: don't return zero on failure path in p54p_probe()
Date: Wed, 02 Jan 2013 02:44:38 +0400 [thread overview]
Message-ID: <50E366D6.7040709@ispras.ru> (raw)
In-Reply-To: <201301012245.43064.chunkeey-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
On 01/02/2013 01:45 AM, Christian Lamparter wrote:
> On Tuesday 01 January 2013 22:11:01 Alexey Khoroshilov wrote:
>> If pci_set_dma_mask() or pci_set_consistent_dma_mask() fails in p54p_probe(),
>> it breaks off initialization, deallocates all resources, but returns zero.
>>
>> The patch implements proper error code propagation.
> Uh, Thanks!
>
> But wait, I think there's another return 0 in the error
> path. See p54pci.c @ line 558:
>
> mem_len = pci_resource_len(pdev, 0);
> if (mem_len < sizeof(...)) {
> dev_err(...)
> goto err_disabled_dev;
> }
>
> Do you think you can add a err = -EINVAL; before the goto too?
You are right! But I would say -ENODEV is more popular error code in
this case.
> [I wonder why this wasn't found by the verification project as
> well? Could it be that pci_resource_len(...) < sizeof(...) is
> somehow always true and this is a dead branch?]
Actually it was found, but I have no direct access to the results at the
moment. My fault.
Would you like I resend the patch to fix both?
--
Best regards,
Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-01-01 22:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-01 21:11 [PATCH] p54pci: don't return zero on failure path in p54p_probe() Alexey Khoroshilov
2013-01-01 21:45 ` Christian Lamparter
[not found] ` <201301012245.43064.chunkeey-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2013-01-01 22:44 ` Alexey Khoroshilov [this message]
[not found] ` <50E366D6.7040709-ufN2psIa012HXe+LvDLADg@public.gmane.org>
2013-01-01 23:53 ` Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E366D6.7040709@ispras.ru \
--to=khoroshilov-ufn2psia012hxe+lvdladg@public$(echo .)gmane.org \
--cc=chunkeey-gM/Ye1E23mwN+BqQ9rBEUg@public$(echo .)gmane.org \
--cc=ldv-project-tpLiQldItUH5n4uC9ZG1Ww@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox