Subject: Re: [RFC(v2) net-next 13/13] ipv6: Complete neighbour entry removal from dst_entry.

From: YOSHIFUJI Hideaki <[email-masked]>
Date: Wed, 16 Jan 2013 23:04:35 +0900

Cong Wang wrote:
> On 01/16/2013 12:46 AM, YOSHIFUJI Hideaki wrote:
>> +#if 0
>>   		if (rt->n && rt->n->dev == dev) {
>>   			rt->n->dev = loopback_dev;
>>   			dev_hold(loopback_dev);
>>   			dev_put(dev);
>>   		}
>> +#endif
> 
> Why commenting this out instead of removing it? As rt->n is totally
> removed, how possible could we reuse this code in future?

I have confirmed that this dev_put()/dev_hold() operation are really
for neigh->dev, which has refcnt for dev, so I agree.

(This is why I need to revisit refcnt 

--yoshfuji