From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6•org>
To: David Miller <davem@davemloft•net>, netdev <netdev@vger•kernel.org>
Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6•org>
Subject: [PATCH net] ipv6: Fix addrconf_dst_alloc() failure check.
Date: Fri, 18 Jan 2013 20:56:41 +0900 [thread overview]
Message-ID: <50F93879.6010201@linux-ipv6.org> (raw)
The function returns NULL on error and it never return error code
embedded in pointer.
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6•org>
---
net/ipv6/addrconf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 420e563..d0a2df2b 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -783,8 +783,8 @@ ipv6_add_addr(struct inet6_dev *idev, const struct in6_addr *addr, int pfxlen,
}
rt = addrconf_dst_alloc(idev, addr, false);
- if (IS_ERR(rt)) {
- err = PTR_ERR(rt);
+ if (!rt) {
+ err = -ENOMEM;
goto out;
}
--
1.7.9.5
next reply other threads:[~2013-01-18 11:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 11:56 YOSHIFUJI Hideaki [this message]
2013-01-18 14:28 ` [PATCH net] ipv6: Fix addrconf_dst_alloc() failure check Eric Dumazet
2013-01-18 14:38 ` YOSHIFUJI Hideaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F93879.6010201@linux-ipv6.org \
--to=yoshfuji@linux-ipv6$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox