From: Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public•gmane.org>
To: Wei Shuai <cpuwolf-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>
Cc: dcbw-H+wXaHxf7aLQT0dZR+AlfA@public•gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org,
peter-Y+HMSxxDrH8@public•gmane.org,
oneukum-l3A5Bk7waGM@public•gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public•gmane.org,
alexey.orishko-0IS4wlFg1OjSUeElwK9/Pw@public•gmane.org,
bjorn-yOkvZcmFvRU@public•gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [PATCH 2/2] CDC_NCM: adding support FLAG_NOARP for Infineon modem platform
Date: Mon, 21 Jan 2013 15:33:00 +0400 [thread overview]
Message-ID: <50FD276C.5010608@mvista.com> (raw)
In-Reply-To: <CACa7zynymtYN4OtTjVNTNdB23eNU4D-G+JqaTxjaPFekRHkRAg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hello.
On 21-01-2013 6:20, Wei Shuai wrote:
> The main problem is that these devices don't support ethernet. They
> support IP (v4 and _maybe_ v6) with an ethernet header. Many of them
> will do ARP (and IPv6 ND) as well to complete the picture, but some of
> them don't and that's what these drivers try to deal with.
>
> Note that most of the devices will run a DHCP server, so there is some
> sort of IP broadcast support. Whether that qualifies as proper ethernet
> broadcast support is another question...
>
> These devices are attempting to bridge an IP-only point-to-point
> interface and an ethernet over USB interface, with the intention to make
> the point-to-point interface look like ethernet to applications and
> users. This is of course always going to be imperfect. But I believe
> that we should aim to help the firmware achive this goal when writing
> drivers instead of working against it. Setting IFF_NOARP and not
> IFF_POINTTOPOINT is one way to do that. ---- by Bjorn Mork <bjorn-yOkvZcmFvRU@public•gmane.org>
Why are you replying with this long story to my simple patch comments? :-)
> 2013/1/21, Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public•gmane.org>:
>> Hello.
>> On 20-01-2013 10:12, Wei Shuai wrote:
>>> Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. we can
>>> define a new common structure wwan_noarp_info.
>> Wrap your lines at 76-80 columns maximum please.
>>> Then more similiar NO ARP devices can be handled easily
s/NO/no/.
>>> Signed-off-by: Wei Shuai <cpuwolf-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>
>>> ---
>>> drivers/net/usb/cdc_ncm.c | 21 +++++++++++++++++++++
>>> 1 files changed, 21 insertions(+), 0 deletions(-)
>>> diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
>>> index 71b6e92..2d699b6 100644
>>> --- a/drivers/net/usb/cdc_ncm.c
>>> +++ b/drivers/net/usb/cdc_ncm.c
>>> @@ -1155,6 +1155,20 @@ static const struct driver_info wwan_info = {
>>> .tx_fixup = cdc_ncm_tx_fixup,
>>> };
>>>
>>> +/* Same as wwan_info, but with IFF_NOARP */
>> FLAG_NOARP, you mean?
>>> +static const struct driver_info wwan_noarp_info = {
>>> + .description = "Mobile Broadband Network Device (NO ARP)",
>>> + .flags = FLAG_POINTTOPOINT | FLAG_NO_SETINT | FLAG_MULTI_PACKET
>>> + | FLAG_WWAN | FLAG_NOARP,
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-01-21 11:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 6:12 [PATCH 1/2] usbnet: add flag FLAG_NOARP for usb net devices Wei Shuai
2013-01-20 6:12 ` [PATCH 2/2] CDC_NCM: adding support FLAG_NOARP for Infineon modem platform Wei Shuai
[not found] ` <1358662329-8294-2-git-send-email-cpuwolf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-01-20 17:13 ` Sergei Shtylyov
2013-01-21 2:20 ` Wei Shuai
[not found] ` <CACa7zynymtYN4OtTjVNTNdB23eNU4D-G+JqaTxjaPFekRHkRAg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-01-21 4:09 ` David Miller
2013-01-21 8:22 ` Wei Shuai
2013-01-21 11:33 ` Sergei Shtylyov [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-01-19 11:53 [PATCH 1/2] introduce flag FLAG_NOARP for usb net devices which cannot do ARP Wei Shuai
[not found] ` <1358596401-7209-1-git-send-email-cpuwolf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-01-19 11:53 ` [PATCH 2/2] CDC_NCM adding support FLAG_NOARP for Infineon modem platform Wei Shuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FD276C.5010608@mvista.com \
--to=sshtylyov-igf4poytycdqt0dzr+alfa@public$(echo .)gmane.org \
--cc=alexey.orishko-0IS4wlFg1OjSUeElwK9/Pw@public$(echo .)gmane.org \
--cc=bjorn-yOkvZcmFvRU@public$(echo .)gmane.org \
--cc=cpuwolf-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=dcbw-H+wXaHxf7aLQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public$(echo .)gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=oneukum-l3A5Bk7waGM@public$(echo .)gmane.org \
--cc=peter-Y+HMSxxDrH8@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox