Subject: Re: [PATCH ethtool] rxclass: Show full 64 bits of user-data in rxclass_print_nfc_spec_ext()

From: Alexander Duyck <[email-masked]>
Date: Tue, 22 Jan 2013 13:07:27 -0800

On 01/22/2013 12:33 PM, Ben Hutchings wrote:
> Previously only the lower 32 bits would be shown.
> 
> Signed-off-by: Ben Hutchings <[email-masked]>
> ---
> I just noticed this bug when applying Yan Burman's patch.  Untested
> since sfc doesn't support this field.
> 
> Ben.
> 
>  rxclass.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/rxclass.c b/rxclass.c
> index 1564b62..cd686a3 100644
> --- a/rxclass.c
> +++ b/rxclass.c
> @@ -49,7 +49,7 @@ static void rxclass_print_nfc_spec_ext(struct ethtool_rx_flow_spec *fsp)
>  		tci = ntohs(fsp->h_ext.vlan_tci);
>  		tcim = ntohs(~fsp->m_ext.vlan_tci);
>  		data = (u64)ntohl(fsp->h_ext.data[0]) << 32;
> -		data = (u64)ntohl(fsp->h_ext.data[1]);
> +		data |= (u64)ntohl(fsp->h_ext.data[1]);
>  		datam = (u64)ntohl(~fsp->m_ext.data[0]) << 32;
>  		datam |= (u64)ntohl(~fsp->m_ext.data[1]);
>  
> 

This looks fine to me.  We didn't use data[0] in ixgbe so we never
noticed this either.

Acked-by: Alexander Duyck <[email-masked]>