public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: netdev <netdev@vger•kernel.org>
Subject: Re: 3.7.3+:  Bad paging request in ip_rcv_finish while running NFS traffic.
Date: Thu, 24 Jan 2013 13:01:35 -0800	[thread overview]
Message-ID: <5101A12F.3040002@candelatech.com> (raw)
In-Reply-To: <1359061140.12374.2395.camel@edumazet-glaptop>

On 01/24/2013 12:59 PM, Eric Dumazet wrote:
> On Thu, 2013-01-24 at 12:03 -0800, Ben Greear wrote:
>> iately processed (and loopback device is hard wired ?)
>>
>> I have not seen any crashes since this change went into my
>> test bed, so I believe this one is finally fixed!  I'm running
>> with your macvlan fixes as well..and even if they did not
>> fix the problem I saw, they at least appear to cause no harm.
>>
>> If you wish, feel free to add:
>>
>> Tested-By:  Ben Greear <greearb@candelatech•com>
>>
>> Thanks,
>> Ben
>
> Just to make sure, you still have the
>
> WARN_ON_ONCE(skb_dst_is_noref(skb))
>
> in netif_rx() ?
>

I have something similar, and I have not seen any splats:

int netif_rx(struct sk_buff *skb)
{
	int ret;

	WARN_ON(skb->_skb_refdst & SKB_DST_NOREF);


I'll keep this in our kernels so when we do .1q vlans and other
sorts of testing we'll get some more coverage.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech•com>
Candela Technologies Inc  http://www.candelatech.com

  reply	other threads:[~2013-01-24 21:01 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-21 21:07 3.7.3+: Bad paging request in ip_rcv_finish while running NFS traffic Ben Greear
2013-01-22  0:32 ` Ben Greear
2013-01-22  4:40   ` Eric Dumazet
2013-01-22  5:57     ` Ben Greear
     [not found]       ` <50FE2A57.3040804-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-22 17:08         ` Ben Greear
     [not found]           ` <50FEC796.5090404-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-22 17:17             ` Eric Dumazet
2013-01-22 17:26               ` Ben Greear
2013-01-22 17:26               ` Eric Dumazet
2013-01-22 22:18                 ` Ben Greear
     [not found]                   ` <50FF102F.2050008-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-23  2:32                     ` Ben Greear
2013-01-23  6:11                       ` Eric Dumazet
2013-01-23  7:14                         ` Ben Greear
     [not found]                           ` <50FF8DEC.9070901-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-23 13:35                             ` Eric Dumazet
2013-01-23 18:15                               ` Ben Greear
2013-01-23 21:43                                 ` Eric Dumazet
2013-01-23 14:42                             ` Eric Dumazet
2013-01-23 21:53                               ` Ben Greear
     [not found]                       ` <50FF4BC9.1060206-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-23 23:55                         ` Ben Greear
     [not found]                           ` <5100785D.8040101-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-24  0:01                             ` Eric Dumazet
2013-01-24  0:13                               ` Ben Greear
     [not found]                                 ` <51007CA8.2050105-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-01-24  0:23                                   ` Eric Dumazet
2013-01-24  0:38                                     ` Ben Greear
2013-01-24  0:45                                       ` Eric Dumazet
2013-01-24  0:51                                         ` Ben Greear
2013-01-24  1:00                                           ` Eric Dumazet
2013-01-24  1:06                                             ` Ben Greear
2013-01-24  1:10                                               ` Eric Dumazet
2013-01-24  1:45                                                 ` Eric Dumazet
2013-01-24  4:26                                                   ` Ben Greear
2013-01-24  5:39                                                     ` Eric Dumazet
2013-01-24 20:03                                                   ` Ben Greear
2013-01-24 20:59                                                     ` Eric Dumazet
2013-01-24 21:01                                                       ` Ben Greear [this message]
2013-01-25 17:44                                                   ` [PATCH] net: loopback: fix a dst refcounting issue Eric Dumazet
2013-01-27  6:32                                                     ` David Miller
2013-01-27 17:25                                                       ` Eric Dumazet
2013-01-28  0:26                                                         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5101A12F.3040002@candelatech.com \
    --to=greearb@candelatech$(echo .)com \
    --cc=eric.dumazet@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox