Subject: Re: Can we replace the msleep(250) in dev.c netdev_wait_allrefs?

From: Ben Greear <[email-masked]>
Date: Tue, 29 Jan 2013 12:24:19 -0800

On 01/29/2013 12:21 PM, Eric Dumazet wrote:
> On Tue, 2013-01-29 at 12:00 -0800, Ben Greear wrote:
>> I think there was a proposal to change it to schedule_timeout_uninterruptible(1);
>> some time ago, but that change never made it upstream (at least not in 3.7.5)?
>>
>> Thanks,
>> Ben
>>
>
> Honestly we should fix the bug at this point, not hide it.
>
> We could use msleep(2500) to make sure people will complain ;)

Well, few will notice that either, or at least are unlikely
to know what to blame.

If we should just never reach that code, maybe a WARN_ON_ONCE() when
we do?

Thanks,
Ben

-- 
Ben Greear <[email-masked]>
Candela Technologies Inc  http://www.candelatech.com