Subject: Re: [PATCH v7 net-next 03/12] bridge: Verify that a vlan is allowed to egress on give port

From: Vlad Yasevich <[email-masked]>
Date: Thu, 31 Jan 2013 15:17:45 -0500

On 01/31/2013 03:03 PM, Michał Mirosław wrote:
> 2013/1/31 Vlad Yasevich <[email-masked]>:
>> When bridge forwards a frame, make sure that a frame is allowed
>> to egress on that port.
>
> For egress checks it might be better to have per-vlan bitmaps of ports
> instead. For unicast this doesn't really change anything, but for
> broadcast and multicast all ports are checked so reading all bits from
> one location is going to be cheaper.

But then one would have to locate that particular bitmap and now we are 
back to a list/hash of vlans each containing port bitmap.  Considering 
how strenuously Stephen wanted a bitmap of vlans, I'll leave it as is 
for now.

>
> [...]
>> -static inline struct net_port_vlans *br_get_vlan_info(struct net_bridge *br)
>> +static inline struct net_port_vlans *br_get_vlan_info(
>> +                                               const struct net_bridge *br)
>>   {
>>          return rcu_dereference(br->vlan_info);
>>   }
>>
>> -static inline struct net_port_vlans *nbp_get_vlan_info(struct net_bridge_port *p)
>> +static inline struct net_port_vlans *nbp_get_vlan_info(
>> +                                               const struct net_bridge_port *p)
>>   {
>>          return rcu_dereference(p->vlan_info);
>>   }
>
> Shouldn't this be in patch 1?

Sure.  'const' wasn't needed until this patch though, but I guess its 
good practice.

Thanks for taking a look
-vlad
> Best Regards,
> Michał Mirosław