From: Amir Vadai <amirv@mellanox•com>
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: David Miller <davem@davemloft•net>, <netdev@vger•kernel.org>,
"Alexander Duyck" <alexander.h.duyck@intel•com>,
Hadar Hen Zion <hadarh@mellanox•com>,
"Or Gerlitz" <ogerlitz@mellanox•com>
Subject: Re: [PATCH net-next V1 00/10] Mellanox Ethernet driver updates 2013-01-30
Date: Wed, 6 Feb 2013 09:24:55 +0200 [thread overview]
Message-ID: <51120547.7090608@mellanox.com> (raw)
In-Reply-To: <1360094899.2857.30.camel@bwh-desktop.uk.solarflarecom.com>
On 05/02/2013 22:08, Ben Hutchings wrote:
> On Thu, 2013-01-31 at 13:51 -0500, David Miller wrote:
>> From: Amir Vadai <amirv@mellanox•com>
>> Date: Thu, 31 Jan 2013 11:07:01 +0200
>>
>>> Hi Dave,
>>>
>>> This series contains updates to mlx4 driver.
>>> Majority of the patches are small bug fixes. Another patch is to expose through
>>> debugfs some HW resources to be used by external tools.
>>>
>>> Patches done against net-next commit 1b13c97: "net/vxlan: Add ethtool drvinfo"
>>>
>>> Changes from V0:
>>> - Removed patch "net/mlx4_en: Add debugfs support". Need to find a standard way
>>> to do it, and no need to delay the other patches.
>>
>> All applied, thanks.
>
> The first time this series was posted (this is actually v2) I raised an
> issue with the changes to interpretation of the VLAN tag in ethtool RX
> NFC commands: <http://article.gmane.org/gmane.linux.network/257392/>.
> The semantics are now definitely inconsistent between sfc and mlx4_en.
> I asked Alexander what ixgbe (first implementation) does with the upper
> 4 bits, with the aim that all three implementations should be
> consistent, but I haven't had an answer to that yet.
>
> Ben.
>
I'm not sure I understand the problem here.
mlx4_en implementation is exactly like what you describe and what
ethtool documentation is describing.
We handle vlan_tci as the whole VLAN tag. Since we're only interested in
the VID in our flow steering, we check that the mask sets only the 12
bits of VID and use it.
From looking at sfc driver - it is exactly same there.
Did I miss something?
Amir.
next prev parent reply other threads:[~2013-02-06 7:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 9:07 [PATCH net-next V1 00/10] Mellanox Ethernet driver updates 2013-01-30 Amir Vadai
2013-01-31 9:07 ` [PATCH net-next V1 01/10] net/mlx4_core: Directly expose fields of HW flow steering rule control segment Amir Vadai
2013-01-31 9:07 ` [PATCH net-next V1 02/10] net/mlx4_core: Set correctly allow_loopback flag Amir Vadai
2013-01-31 9:07 ` [PATCH net-next V1 03/10] net/mlx4_en: Fix ip/udp steering rules multicast mac when attached via ethtool Amir Vadai
2013-01-31 9:07 ` [PATCH net-next V1 04/10] net/mlx4_en: Validate VLAN IDs provided in ethtool flow steering rules Amir Vadai
2013-01-31 9:07 ` [PATCH net-next V1 05/10] net/mlx4_en: Fix vlan mask for ethtool " Amir Vadai
2013-01-31 9:07 ` [PATCH net-next V1 06/10] net/mlx4_en: Block insertion of ethtool steering rules while the interface is down Amir Vadai
2013-01-31 9:07 ` [PATCH net-next V1 07/10] net/mlx4_en: Fix ethtool rules leftovers after module unloaded Amir Vadai
2013-01-31 9:07 ` [PATCH net-next V1 08/10] net/mlx4_core: Use firmware driven flow steering hash mode Amir Vadai
2013-01-31 9:07 ` [PATCH net-next V1 09/10] net/mlx4_en: Don't reassign port mac address on firmware that supports it Amir Vadai
2013-01-31 9:07 ` [PATCH net-next V1 10/10] net/mlx4_en: Fix transmit timeout when driver restarts port Amir Vadai
2013-01-31 18:51 ` [PATCH net-next V1 00/10] Mellanox Ethernet driver updates 2013-01-30 David Miller
2013-02-05 20:08 ` Ben Hutchings
2013-02-05 20:30 ` David Miller
2013-02-06 7:24 ` Amir Vadai [this message]
2013-02-06 15:46 ` Ben Hutchings
2013-02-06 16:58 ` Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51120547.7090608@mellanox.com \
--to=amirv@mellanox$(echo .)com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=hadarh@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox