Subject: Re: [PATCH V2] bgmac: validate MAC addr

From: Florian Fainelli <[email-masked]>
Date: Thu, 07 Feb 2013 11:19:54 +0100

On 02/07/2013 11:14 AM, Rafał Miłecki wrote:
> Signed-off-by: Rafał Miłecki <[email-masked]>

This is looking good, however some commit message is desirable, 
especially as you are no longer just validating the ethernet MAC 
address, but also generating a new one. Something along those lines 
would probably be enough:

"This patch changes bgmac_probe() to check for a valid Ethernet MAC 
address and in case it is not, will generate a valid random one, such 
that the adapter is still usable."

Thanks!

> ---
> V2: generate random addr
> ---
>   drivers/net/ethernet/broadcom/bgmac.c |    6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
> index d08a4af..f90d1dc 100644
> --- a/drivers/net/ethernet/broadcom/bgmac.c
> +++ b/drivers/net/ethernet/broadcom/bgmac.c
> @@ -1318,6 +1318,12 @@ static int bgmac_probe(struct bcma_device *core)
>   		return -ENOTSUPP;
>   	}
>   
> +	if (!is_valid_ether_addr(mac)) {
> +		dev_err(&core->dev, "Invalid MAC addr: %pM\n", mac);
> +		eth_random_addr(mac);
> +		dev_warn(&core->dev, "Using random MAC: %pM\n", mac);
> +	}
> +
>   	/* Allocation and references */
>   	net_dev = alloc_etherdev(sizeof(*bgmac));
>   	if (!net_dev)