public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6•org>
To: netdev@vger•kernel.org, linux1394-devel@lists•sourceforge.net
Cc: stephan.gatzka@gmail•com, davem@davemloft•net,
	stefanr@s5r6•in-berlin.de, yoshfuji@linux-ipv6•org
Subject: [RFC net-next (TAKE 3) 4/6] firewire net: Allocate address handler before registering net_device.
Date: Mon, 11 Feb 2013 02:47:09 +0900	[thread overview]
Message-ID: <5117DD1D.9050802@linux-ipv6.org> (raw)

Since we are going to embedding our FIFO address into our pseudo HW
address, let's allocate FIFO address before registering net_device.

Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6•org>
---
 drivers/firewire/net.c |   37 +++++++++++++++++--------------------
 1 file changed, 17 insertions(+), 20 deletions(-)

diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c
index 2c263de..851aef0 100644
--- a/drivers/firewire/net.c
+++ b/drivers/firewire/net.c
@@ -1124,19 +1124,6 @@ static int fwnet_broadcast_start(struct fwnet_device *dev)
 	unsigned long offset;
 	unsigned u;
 
-	if (dev->local_fifo == FWNET_NO_FIFO_ADDR) {
-		dev->handler.length = 4096;
-		dev->handler.address_callback = fwnet_receive_packet;
-		dev->handler.callback_data = dev;
-
-		retval = fw_core_add_address_handler(&dev->handler,
-					&fw_high_memory_region);
-		if (retval < 0)
-			goto failed_initial;
-
-		dev->local_fifo = dev->handler.offset;
-	}
-
 	max_receive = 1U << (dev->card->max_receive + 1);
 	num_packets = (FWNET_ISO_PAGE_COUNT * PAGE_SIZE) / max_receive;
 
@@ -1217,9 +1204,6 @@ static int fwnet_broadcast_start(struct fwnet_device *dev)
 	fw_iso_context_destroy(context);
 	dev->broadcast_rcv_context = NULL;
  failed_context_create:
-	fw_core_remove_address_handler(&dev->handler);
- failed_initial:
-	dev->local_fifo = FWNET_NO_FIFO_ADDR;
 
 	return retval;
 }
@@ -1536,6 +1520,15 @@ static int fwnet_probe(struct device *_dev)
 	dev->card = card;
 	dev->netdev = net;
 
+	dev->handler.length = 4096;
+	dev->handler.address_callback = fwnet_receive_packet;
+	dev->handler.callback_data = dev;
+
+	ret = fw_core_add_address_handler(&dev->handler, &fw_high_memory_region);
+	if (ret < 0)
+		goto out;
+	dev->local_fifo = dev->handler.offset;
+
 	/*
 	 * Use the RFC 2734 default 1500 octets or the maximum payload
 	 * as initial MTU
@@ -1559,10 +1552,13 @@ static int fwnet_probe(struct device *_dev)
 	if (ret && allocated_netdev) {
 		unregister_netdev(net);
 		list_del(&dev->dev_link);
-	}
  out:
-	if (ret && allocated_netdev)
+		if (dev->local_fifo != FWNET_NO_FIFO_ADDR) {
+			fw_core_remove_address_handler(&dev->handler);
+			dev->local_fifo = FWNET_NO_FIFO_ADDR;
+		}
 		free_netdev(net);
+	}
 
 	mutex_unlock(&fwnet_device_mutex);
 
@@ -1603,8 +1599,9 @@ static int fwnet_remove(struct device *_dev)
 	if (list_empty(&dev->peer_list)) {
 		unregister_netdev(net);
 
-		if (dev->local_fifo != FWNET_NO_FIFO_ADDR)
-			fw_core_remove_address_handler(&dev->handler);
+		fw_core_remove_address_handler(&dev->handler);
+		dev->local_fifo = FWNET_NO_FIFO_ADDR;
+
 		if (dev->broadcast_rcv_context) {
 			fw_iso_context_stop(dev->broadcast_rcv_context);
 			fw_iso_buffer_destroy(&dev->broadcast_rcv_buffer,
-- 
1.7.9.5

                 reply	other threads:[~2013-02-10 17:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:2c263de dfblob:851aef0 )
 OR (
bs:"[RFC net-next (TAKE 3) 4/6] firewire net: Allocate address handler before registering net_device." )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5117DD1D.9050802@linux-ipv6.org \
    --to=yoshfuji@linux-ipv6$(echo .)org \
    --cc=davem@davemloft$(echo .)net \
    --cc=linux1394-devel@lists$(echo .)sourceforge.net \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=stefanr@s5r6$(echo .)in-berlin.de \
    --cc=stephan.gatzka@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox