From: Or Gerlitz <ogerlitz@mellanox•com>
To: "Hefty, Sean" <sean.hefty@intel•com>
Cc: "linux-rdma@vger•kernel.org" <linux-rdma@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"David Miller (davem@davemloft•net)" <davem@davemloft•net>,
Roland Dreier <roland@kernel•org>
Subject: Re: [PATCH v4 1/9] rdma/cm: define native IB address
Date: Wed, 13 Feb 2013 14:51:11 +0200 [thread overview]
Message-ID: <511B8C3F.9070002@mellanox.com> (raw)
In-Reply-To: <1828884A29C6694DAF28B7E6B8A8237368B99D59@ORSMSX101.amr.corp.intel.com>
On 11/02/2013 20:02, Hefty, Sean wrote:
>> Define AF_IB and sockaddr_ib to allow the rdma_cm to use native IB addressing.
>>
>> Signed-off-by: Sean Hefty <sean.hefty@intel•com>
>> ---
>> include/linux/socket.h | 2 +
>> include/rdma/ib.h | 89 ++++++++++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 91 insertions(+), 0 deletions(-)
>> create mode 100644 include/rdma/ib.h
>>
>> diff --git a/include/linux/socket.h b/include/linux/socket.h
>> index 9a546ff..17a33f7 100644
>> --- a/include/linux/socket.h
>> +++ b/include/linux/socket.h
>> @@ -167,6 +167,7 @@ struct ucred {
>> #define AF_PPPOX 24 /* PPPoX sockets */
>> #define AF_WANPIPE 25 /* Wanpipe API Sockets */
>> #define AF_LLC 26 /* Linux LLC */
>> +#define AF_IB 27 /* Native InfiniBand address */
> ...
>
>> diff --git a/include/rdma/ib.h b/include/rdma/ib.h
> ...
>
>> +struct sockaddr_ib {
>> + unsigned short int sib_family; /* AF_IB */
>> + __be16 sib_pkey;
>> + __be32 sib_flowinfo;
>> + struct ib_addr sib_addr;
>> + __be64 sib_sid;
>> + __be64 sib_sid_mask;
>> + __u64 sib_scope_id;
>> +};
> Dave/Roland/anyone, is there any feedback on this approach?
>
> If there's hesitation to add new address families to socket.h, I could instead use definitions local to the rdma_cm. This has the potential to result in conflicts if the rdma_cm is expanded for other address families, though such conflicts seem unlikely.
>
>
I don't see why not add new address family if it comes to serve a real
world use case, which seems to be the case from the description you
provided in the cover letter.
Or.
next prev parent reply other threads:[~2013-02-13 12:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 21:56 [PATCH v4 0/9] rdma/cm: Add support for native Infiniband addressing sean.hefty-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1358891797-14625-1-git-send-email-sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-01-22 21:56 ` [PATCH v4 1/9] rdma/cm: define native IB address sean.hefty-ral2JQCrhuEAvxtiuMwx3w
2013-02-11 18:02 ` Hefty, Sean
2013-02-13 12:51 ` Or Gerlitz [this message]
[not found] ` <1828884A29C6694DAF28B7E6B8A8237368B99D59-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2013-03-01 3:49 ` Hefty, Sean
2013-02-13 12:56 ` Or Gerlitz
2013-01-22 21:56 ` [PATCH v4 2/9] rdma/cm: Include AF_IB in loopback and any address checks sean.hefty-ral2JQCrhuEAvxtiuMwx3w
2013-01-22 21:56 ` [PATCH v4 4/9] rdma/cm: Update port reservation to support AF_IB sean.hefty-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1358891797-14625-5-git-send-email-sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-02-13 11:09 ` Or Gerlitz
[not found] ` <511B7474.3040201-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-02-13 17:44 ` Hefty, Sean
2013-02-13 18:10 ` Jason Gunthorpe
2013-02-13 18:19 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A8237368B9A432-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2013-02-13 18:26 ` Jason Gunthorpe
2013-02-13 18:37 ` Hefty, Sean
2013-01-22 21:56 ` [PATCH v4 6/9] rdma/cm: Do not modify sa_family when setting loopback address sean.hefty-ral2JQCrhuEAvxtiuMwx3w
2013-01-22 21:56 ` [PATCH v4 7/9] rdma/cm: Add helper functions to return id address information sean.hefty-ral2JQCrhuEAvxtiuMwx3w
2013-02-13 12:44 ` Or Gerlitz
2013-01-22 21:56 ` [PATCH v4 8/9] rdma/cm: Restrict AF_IB loopback to binding to IB devices only sean.hefty-ral2JQCrhuEAvxtiuMwx3w
2013-01-22 21:56 ` [PATCH v4 9/9] rdma/cm: Verify that source and dest sa_family are the same sean.hefty-ral2JQCrhuEAvxtiuMwx3w
2013-01-22 21:56 ` [PATCH v4 3/9] ib/addr: Add AF_IB support to ip_addr_size sean.hefty
2013-01-22 21:56 ` [PATCH v4 5/9] rdma/cm: Allow user to specify AF_IB when binding sean.hefty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511B8C3F.9070002@mellanox.com \
--to=ogerlitz@mellanox$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roland@kernel$(echo .)org \
--cc=sean.hefty@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox