From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6•org>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net,
Ben Greear <greearb@candelatech•com>,
Vlad Yasevich <vyasevic@redhat•com>,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6•org>
Subject: Re: [RFC PATCH net-next (V2)] ipv6: Queue fragments per interface for multicast/link-local addresses.
Date: Sat, 16 Feb 2013 20:39:29 +0900 [thread overview]
Message-ID: <511F6FF1.9000004@linux-ipv6.org> (raw)
In-Reply-To: <1360995918.19353.56.camel@edumazet-glaptop>
Eric Dumazet wrote:
> On Sat, 2013-02-16 at 14:49 +0900, YOSHIFUJI Hideaki wrote:
>> We should queue fragments for the same link-local address on
>> different interfaces (e.g. fe80::1%eth0 and fe80::1%eth1) to the
>> different queue, because of nature of addressing architecture.
>>
>> Similarly, we should queue fragments for multicast on different
>> interface to the different queue. This is okay because
>> application joins group on speicific interface, and multicast
>> traffic is expected only on that interface.
>>
>> CC: Ben Greear <greearb@candelatech•com>
>> CC: Vlad Yasevich <vyasevic@redhat•com>
>> CC: Eric Dumazet <eric.dumazet@gmail•com>
>> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6•org>
>> ---
>
> I would definitely ask advice from Patrick & Pablo on this patch.
>
> If a router uses several links in aggregation (but no bonding dev), we
> might break fragmentation/reassembly.
Could you elaborate, please?
The patch does not compare incoming interface if address is
non-link-local unicast address.
--yoshfuji
next prev parent reply other threads:[~2013-02-16 11:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-16 5:49 [RFC PATCH net-next (V2)] ipv6: Queue fragments per interface for multicast/link-local addresses YOSHIFUJI Hideaki
2013-02-16 6:25 ` Eric Dumazet
2013-02-16 11:39 ` YOSHIFUJI Hideaki [this message]
2013-02-16 16:15 ` Eric Dumazet
2013-02-16 18:53 ` Vlad Yasevich
2013-02-16 16:44 ` [RFC PATCH net-next (V2, RESENT)] " YOSHIFUJI Hideaki
2013-02-18 13:19 ` Erik Hugne
2013-03-16 7:47 ` Hannes Frederic Sowa
2013-03-17 0:50 ` YOSHIFUJI Hideaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511F6FF1.9000004@linux-ipv6.org \
--to=yoshfuji@linux-ipv6$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=greearb@candelatech$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vyasevic@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox