From: Hauke Mehrtens <hauke@hauke-m•de>
To: Stephen Hemminger <stephen@networkplumber•org>
Cc: davem@davemloft•net, zajec5@gmail•com, netdev@vger•kernel.org
Subject: Re: [PATCH] bgmac: fix unaligned accesses to network headers
Date: Sat, 16 Feb 2013 20:01:32 +0100 [thread overview]
Message-ID: <511FD78C.5000805@hauke-m.de> (raw)
In-Reply-To: <20130216103612.190d908e@nehalam.linuxnetplumber.net>
On 02/16/2013 07:36 PM, Stephen Hemminger wrote:
> On Sat, 16 Feb 2013 15:32:34 +0100
> Hauke Mehrtens <hauke@hauke-m•de> wrote:
>
>> Without this patch I get many unaligned access warnings per packet,
>> this patches fixes them all. This should improve performance ony some
>> systems like mips.
>>
>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m•de>
>> ---
>> drivers/net/ethernet/broadcom/bgmac.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
>> index d341090..f9b1bc8 100644
>> --- a/drivers/net/ethernet/broadcom/bgmac.c
>> +++ b/drivers/net/ethernet/broadcom/bgmac.c
>> @@ -301,8 +301,9 @@ static int bgmac_dma_rx_read(struct bgmac *bgmac, struct bgmac_dma_ring *ring,
>> bgmac_err(bgmac, "Found poisoned packet at slot %d, DMA issue!\n",
>> ring->start);
>> } else {
>> - new_skb = netdev_alloc_skb(bgmac->net_dev, len);
>> + new_skb = netdev_alloc_skb(bgmac->net_dev, len + 2);
>> if (new_skb) {
>> + skb_reserve(new_skb, 2);
>> skb_put(new_skb, len);
>> skb_copy_from_linear_data_offset(skb, BGMAC_RX_FRAME_OFFSET,
>> new_skb->data,
>
> NAK. Use netdev_alloc_skb_ip_align instead.
> It is less error prone, and handles case of architectures where unaligned is faster.
Thanks for the hint, I will send a better version of this patch.
Hauke
next prev parent reply other threads:[~2013-02-16 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-16 14:32 [PATCH] bgmac: fix unaligned accesses to network headers Hauke Mehrtens
2013-02-16 18:36 ` Stephen Hemminger
2013-02-16 19:01 ` Hauke Mehrtens [this message]
2013-02-18 16:14 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511FD78C.5000805@hauke-m.de \
--to=hauke@hauke-m$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
--cc=zajec5@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox