Subject: Re: [PATCH v2 1/1] drivers: net: davinci_cpdma: acknowledge interrupt properly

From: Mugunthan V N <[email-masked]>
Date: Sun, 17 Feb 2013 15:04:42 +0530

On 2/16/2013 1:35 AM, David Miller wrote:
> From: Mugunthan V N <[email-masked]>
> Date: Thu, 14 Feb 2013 23:56:46 +0530
>
>> +enum {
>> +	CPDMA_EOI_RX_THRESH = 0,
>> +	CPDMA_EOI_RX,
>> +	CPDMA_EOI_TX,
>> +	CPDMA_EOI_MISC,
>> +};
> Do not use enumerations for hardware register values, which must be
> exact, otherwise you are potentially going to succumb to the vagaries
> of C language enumeration value assignment.
Will change enum to define and submit next version patch.

Regards
Mugunthan V N