public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Chris Friesen <chris.friesen@genband•com>
To: Stephen Hemminger <stephen@networkplumber•org>
Cc: Eric Dumazet <eric.dumazet@gmail•com>, netdev <netdev@vger•kernel.org>
Subject: Re: why is it not allowed to add a new socket protocol family as an external module?
Date: Thu, 21 Feb 2013 10:19:23 -0600	[thread overview]
Message-ID: <5126490B.4020206@genband.com> (raw)
In-Reply-To: <20130221080425.72e36f6d@nehalam.linuxnetplumber.net>

On 02/21/2013 10:04 AM, Stephen Hemminger wrote:

> It is not impossible to make this dynamic, you would need to make the table an allocated
> object and use proper locking like RCU. Oh, and because it is using GPL, the symbols
> would have to be EXPORT_SYMBOL_GPL(), so any dream of proprietary stacks there would
> be skating on even thinner ice.
> The lockdep stuff makes it more complicated but not impossible.

I'm not even thinking about closed-source stacks.  In our particular 
case the use-case is highly proprietary (not to mention legacy and 
obscure) but GPL-compliant.

> The bigger issue is how would you manage statically assigned id's which
> are not visible int headers or kernel source. How would you keep AF_VENDOR_PROTOCOL1 from
> not colliding with AF_VENDOR_PROTOCOL2?

I wouldn't expect many people to have multiple dynamic protocols loaded, 
so I'm not sure this would be a big problem.

For a fully generic solution I think we'd need to do dynamic numbering 
and export the mapping somewhere like /sys/class/net or 
/proc/sys/net/core/.  This would makes things a bit non-standard for the 
userspace code, but would allow arbitrary numbers of dynamic protocols 
without collision.

Or maybe we get really crazy and do protocol namespaces. :)

Chris

  reply	other threads:[~2013-02-21 16:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-20 16:56 why is it not allowed to add a new socket protocol family as an external module? Chris Friesen
2013-02-20 23:23 ` Stephen Hemminger
2013-02-21  0:44   ` Chris Friesen
2013-02-21  1:05     ` David Miller
2013-02-21 15:19       ` Chris Friesen
2013-02-21  1:39     ` Eric Dumazet
2013-02-21 15:47       ` Chris Friesen
2013-02-21 16:04         ` Stephen Hemminger
2013-02-21 16:19           ` Chris Friesen [this message]
2013-02-21 16:43         ` Eric Dumazet
2013-02-21 17:58           ` Chris Friesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5126490B.4020206@genband.com \
    --to=chris.friesen@genband$(echo .)com \
    --cc=eric.dumazet@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=stephen@networkplumber$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox