From: Jiri Slaby <jslaby@suse•cz>
To: Chen Gang <gang.chen@asianux•com>
Cc: Jiri Kosina <jkosina@suse•cz>,
isdn@linux-pingi•de, Greg KH <gregkh@linuxfoundation•org>,
Alan Cox <alan@lxorguk•ukuu.org.uk>,
netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH] drivers/isdn: break out of the loop after call isdn_tty_send_msg
Date: Thu, 28 Feb 2013 10:54:54 +0100 [thread overview]
Message-ID: <512F296E.1050303@suse.cz> (raw)
In-Reply-To: <512EC79C.3010700@asianux.com>
On 02/28/2013 03:57 AM, Chen Gang wrote:
>
> need break out of the loop after call isdn_tty_send_msg.
> isdn_tty_send_msg is intended to eat the rest of the string.
> so need not scan again the string which appended "+M...".
Yes, looks good.
> Signed-off-by: Chen Gang <gang.chen@asianux•com>
> ---
> drivers/isdn/i4l/isdn_tty.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/isdn/i4l/isdn_tty.c b/drivers/isdn/i4l/isdn_tty.c
> index d8a7d83..8ac7b33 100644
> --- a/drivers/isdn/i4l/isdn_tty.c
> +++ b/drivers/isdn/i4l/isdn_tty.c
> @@ -3587,7 +3587,7 @@ isdn_tty_parse_at(modem_info *info)
> case 'M': /* MESSAGE */
> p++;
> isdn_tty_send_msg(info, m, p);
> - break;
> + goto tail;
> default:
> PARSE_ERROR;
> }
> @@ -3601,6 +3601,8 @@ isdn_tty_parse_at(modem_info *info)
> PARSE_ERROR;
> }
> }
> +
> +tail:
> #ifdef CONFIG_ISDN_AUDIO
> if (!info->vonline)
> #endif
>
--
js
suse labs
next prev parent reply other threads:[~2013-02-28 9:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 9:32 [Suggestion] drivers/isdn: about the loop after call isdn_tty_send_msg Chen Gang
2013-02-27 10:00 ` Jiri Slaby
2013-02-27 10:08 ` Chen Gang
2013-02-28 2:57 ` [PATCH] drivers/isdn: break out of " Chen Gang
2013-02-28 9:54 ` Jiri Slaby [this message]
2013-03-15 2:02 ` Chen Gang
2013-03-20 5:03 ` Chen Gang
2013-03-25 3:27 ` Chen Gang
2013-03-29 1:56 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512F296E.1050303@suse.cz \
--to=jslaby@suse$(echo .)cz \
--cc=alan@lxorguk$(echo .)ukuu.org.uk \
--cc=gang.chen@asianux$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=isdn@linux-pingi$(echo .)de \
--cc=jkosina@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox