Subject: Re: NET: FEC: dynamtic check DMA desc buff type

From: Greg Ungerer <[email-masked]>
Date: Mon, 04 Mar 2013 15:06:51 +1000

Hi Frank,

On 04/03/13 14:35, Frank Li wrote:
> 2013/3/4 Greg Ungerer <[email-masked]>:
>> Commit ff43da86c69d76a726ffe7d1666148960dc1d108 ("NET: FEC: dynamtic
>> check DMA desc buff type") breaks building of the fec ethernet driver
>> for non CONFIG_ARCH_MXC targets.
>>
>> For example building for ColdFire devices with FEC hardware now
>> fails like this
>>
>> drivers/net/ethernet/freescale/fec.c: In function ‘fec_enet_get_nextdesc’:
>> drivers/net/ethernet/freescale/fec.c:215:18: error: invalid use of undefined
>> type ‘struct bufdesc_ex’
>> drivers/net/ethernet/freescale/fec.c: In function ‘fec_enet_get_prevdesc’:
>> drivers/net/ethernet/freescale/fec.c:224:18: error: invalid use of undefined
>> type ‘struct bufdesc_ex’
>> drivers/net/ethernet/freescale/fec.c: In function ‘fec_enet_start_xmit’:
>> drivers/net/ethernet/freescale/fec.c:286:37: error: arithmetic on pointer to
>> an incomplete type
>> drivers/net/ethernet/freescale/fec.c:287:13: error: arithmetic on pointer to
>> an incomplete type
>> drivers/net/ethernet/freescale/fec.c:324:7: error: dereferencing pointer to
>> incomplete type
>> etc....
>>
>> These where generated on 3.9-rc1.
>>
>> Can you please fix?
>
> I can fix it.
> I have not build environment to test.
> Can you help me to test it?

Oh yes, I can test any fixes.

If you had a m68k-linux compiler you can build with the
arch/m68k/configs/m5208evb_defconfig which shows the problem.

Regards
Greg

>>   --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to [email-masked]
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>