From: Linda Walsh <lkml@tlinx•org>
To: LKML <linux-lkml@vger•kernel.org>,
Linux Kernel Network Developers <netdev@vger•kernel.org>
Subject: upgrade to 3.8.1 : BUG Scheduling while atomic in bonding driver:
Date: Thu, 07 Mar 2013 00:52:35 -0800 [thread overview]
Message-ID: <51385553.8060003@tlinx.org> (raw)
I am *not* seeing the bug in 3.8.2 with the 2nd patch applied (in
addition to the first)...
Michael Wang wrote:
>
>
> And both bond_enslave() and bond_mii_monitor() are using bond_update_speed_duplex()
> with preempt disabled.
>
> Along with the changes in bond_enslave(), I think you also need this (untested):
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 11d01d6..9af143a 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -2373,7 +2373,9 @@ static void bond_miimon_commit(struct bonding *bond)
> bond_set_backup_slave(slave);
> }
>
> + read_unlock(&bond->lock);
> bond_update_speed_duplex(slave);
> + read_lock(&bond->lock);
>
> pr_info("%s: link status definitely up for interface %s, %u Mbps %s duplex.\n",
> bond->dev->name, slave->dev->name,
>
>
> Regards,
> Michael Wang
>
>
>
next reply other threads:[~2013-03-07 8:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 8:52 Linda Walsh [this message]
[not found] <513063B4.8070604@tlinx.org>
2013-03-01 16:24 ` upgrade to 3.8.1 : BUG Scheduling while atomic in bonding driver: Eric Dumazet
[not found] ` <51317FCF.1070400@tlinx.org>
2013-03-02 5:21 ` Linda Walsh
2013-03-07 5:51 ` Michael Wang
2013-03-07 7:05 ` Linda Walsh
2013-03-07 7:48 ` Michael Wang
2013-03-07 8:04 ` Michael Wang
[not found] ` <513854E6.9010709@tlinx.org>
2013-03-07 9:50 ` Michael Wang
2013-03-07 14:59 ` Veaceslav Falico
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51385553.8060003@tlinx.org \
--to=lkml@tlinx$(echo .)org \
--cc=linux-lkml@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox