Subject: Re: [PATCH 1/3] driver: net: ethernet: cpsw: implement ethtool get/set phy setting

From: Mugunthan V N <[email-masked]>
Date: Fri, 8 Mar 2013 12:53:18 +0530

On 3/8/2013 1:29 AM, Ben Hutchings wrote:
> On Thu, 2013-03-07 at 14:24 +0100, Peter Korsgaard wrote:
>>>>>>> "M" == Mugunthan V N <[email-masked]> writes:
>>   M> This patch implements get/set of the phy settings via ethtool apis
>>   M> Signed-off-by: Mugunthan V N <[email-masked]>
>>   M> ---
>>   M>  Documentation/devicetree/bindings/net/cpsw.txt |    3 +++
>>   M>  drivers/net/ethernet/ti/cpsw.c                 |   32 ++++++++++++++++++++++++
>>   M>  include/linux/platform_data/cpsw.h             |    1 +
>>   M>  3 files changed, 36 insertions(+)
>>
>>   M> diff --git a/Documentation/devicetree/bindings/net/cpsw.txt b/Documentation/devicetree/bindings/net/cpsw.txt
>>   M> index ecfdf75..8d61300 100644
>>   M> --- a/Documentation/devicetree/bindings/net/cpsw.txt
>>   M> +++ b/Documentation/devicetree/bindings/net/cpsw.txt
>>   M> @@ -20,6 +20,7 @@ Required properties:
>>   M>  - cpts_clock_shift	: Denominator to convert input clock ticks into nanoseconds
>>   M>  - phy_id		: Specifies slave phy id
>>   M>  - mac-address		: Specifies slave MAC address
>>   M> +- ethtool-active-slave	: Specifies the slave to use for ethtool command
>>
>> That again sounds like something Linux specific rather than a hardware
>> property.
> Yes, indeed.  Isn't it redundant with the phy_id?
>
> Ben.
phy_id is part of slave data and will be present for both the slaves.
so phy_id cannot be used for get/set phy setting until phy framework
allows to change settings without going through eth interface.

Regards
Mugunthan V N