From: Sekhar Nori <nsekhar-l0cyMroinI0@public•gmane.org>
To: Prabhakar Lad <prabhakar.csengg-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>
Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public•gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org, "Lad,
Prabhakar" <prabhakar.lad-l0cyMroinI0@public•gmane.org>,
Heiko Schocher <hs-ynQEQJNshbs@public•gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public•gmane.org
Subject: Re: [PATCH v2 4/6] ARM: davinci: da850: add DT node for eth0.
Date: Fri, 8 Mar 2013 15:21:33 +0530 [thread overview]
Message-ID: <5139B4A5.2050404@ti.com> (raw)
In-Reply-To: <CA+V-a8tSjF0Zz53_v=d-hUdKK4ihK_aLceOYnmQFhhKLOx3y1g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 3/8/2013 3:15 PM, Prabhakar Lad wrote:
> Sekhar,
>
> On Mon, Feb 4, 2013 at 11:20 PM, Sekhar Nori <nsekhar-l0cyMroinI0@public•gmane.org> wrote:
>> On 2/4/2013 10:37 AM, Prabhakar Lad wrote:
>>> Sekhar ,
>>>
>>> On Sun, Feb 3, 2013 at 5:33 PM, Sekhar Nori <nsekhar-l0cyMroinI0@public•gmane.org> wrote:
>>>> On 1/28/2013 7:17 PM, Prabhakar Lad wrote:
>>>>> From: Lad, Prabhakar <prabhakar.lad-l0cyMroinI0@public•gmane.org>
>>>>>
>>>>> Add eth0 device tree node information and pinmux for mii to da850 by
>>>>> providing interrupt details and local mac address of eth0.
>>>>>
>>>>> Signed-off-by: Lad, Prabhakar <prabhakar.lad-l0cyMroinI0@public•gmane.org>
>>>>> Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public•gmane.org
>>>>> Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
>>>>> Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org
>>>>> Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
>>>>> Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public•gmane.org
>>>>> Cc: Sekhar Nori <nsekhar-l0cyMroinI0@public•gmane.org>
>>>>> Cc: Heiko Schocher <hs-ynQEQJNshbs@public•gmane.org>
>>>>> ---
>>>>> arch/arm/boot/dts/da850-evm.dts | 5 +++++
>>>>> arch/arm/boot/dts/da850.dtsi | 35 +++++++++++++++++++++++++++++++++++
>>>>> 2 files changed, 40 insertions(+), 0 deletions(-)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
>>>>> index a319491..19aa2b3 100644
>>>>> --- a/arch/arm/boot/dts/da850-evm.dts
>>>>> +++ b/arch/arm/boot/dts/da850-evm.dts
>>>>> @@ -30,6 +30,11 @@
>>>>> mdio: davinci_mdio@1e24000 {
>>>>> status = "okay";
>>>>> };
>>>>> + eth0: emac@1e20000 {
>>>>> + status = "okay";
>>>>> + pinctrl-names = "default";
>>>>> + pinctrl-0 = <&mii_pins>;
>>>>> + };
>>>>> };
>>>>> nand_cs3@62000000 {
>>>>> status = "okay";
>>>>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
>>>>> index ba28f2d..76905f3 100644
>>>>> --- a/arch/arm/boot/dts/da850.dtsi
>>>>> +++ b/arch/arm/boot/dts/da850.dtsi
>>>>> @@ -56,6 +56,26 @@
>>>>> 0x30 0x01100000 0x0ff00000
>>>>> >;
>>>>> };
>>>>> + mii_pins: pinmux_mii_pins {
>>>>> + pinctrl-single,bits = <
>>>>> + /*
>>>>> + * MII_TXEN, MII_TXCLK, MII_COL
>>>>> + * MII_TXD_3, MII_TXD_2, MII_TXD_1
>>>>> + * MII_TXD_0
>>>>> + */
>>>>> + 0x8 0x88888880 0xfffffff0
>>>>> + /*
>>>>> + * MII_RXER, MII_CRS, MII_RXCLK
>>>>> + * MII_RXDV, MII_RXD_3, MII_RXD_2
>>>>> + * MII_RXD_1, MII_RXD_0
>>>>> + */
>>>>> + 0xc 0x88888888 0xffffffff
>>>>> + /* MDIO_CLK, MDIO_D */
>>>>
>>>> You call this mii_pins, but include mdio pins in there as well. Can you
>>>> separate them out? Then some board which uses rmii can simply reuse the
>>>> entry.
>>>>
>>> Ok makes sense.
>>>
>>>>> + 0x10 0x00222288 0x00ffffff
>>>>> + /* GPIO2_6 */
>>>>> + 0x18 0x00000080 0x000000f0
>>>>
>>>> This is SoC specific pin list. Such board specific pins should not make
>>>> it here.
>>>>
>>> Ok, so this should be set up using GPIO API's ?
>>
>> Yes, the pins ultimately will be controlled by gpiolib APIs, but the
>> pins should be defined under the eth node in .dts
>>
> You mean '0x18 0x00000080 0x000000f0' still needs to defined in eth0 node ?
> Can you elaborate and give some pointers.
Since the GPIO usage for ethernet is board specific, it cannot be in
.dtsi which is SoC generic. I am suggesting do in the .dts file which is
board specific.
Thanks,
Sekhar
next prev parent reply other threads:[~2013-03-08 9:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 13:47 [PATCH v2 0/6] ARM: davinci: da850: add ethernet driver DT support Prabhakar Lad
2013-01-28 13:47 ` [PATCH v2 1/6] ARM: davinci: da850: fix clock lookup for mdio device Prabhakar Lad
[not found] ` <1359380879-26306-2-git-send-email-prabhakar.lad-l0cyMroinI0@public.gmane.org>
2013-02-03 11:14 ` Sekhar Nori
[not found] ` <510E469D.9020807-l0cyMroinI0@public.gmane.org>
2013-02-03 11:38 ` Prabhakar Lad
2013-01-28 13:47 ` [PATCH v2 2/6] ARM: davinci: da850: add DT node " Prabhakar Lad
[not found] ` <1359380879-26306-3-git-send-email-prabhakar.lad-l0cyMroinI0@public.gmane.org>
2013-02-03 11:53 ` Sekhar Nori
[not found] ` <510E4FB8.4050705-l0cyMroinI0@public.gmane.org>
2013-02-03 12:17 ` Prabhakar Lad
2013-01-28 13:47 ` [PATCH v2 3/6] ARM: davinci: da850: add OF_DEV_AUXDATA entry for mdio Prabhakar Lad
2013-01-28 13:47 ` [PATCH v2 4/6] ARM: davinci: da850: add DT node for eth0 Prabhakar Lad
2013-02-03 12:03 ` Sekhar Nori
2013-02-04 5:07 ` Prabhakar Lad
2013-02-04 17:50 ` Sekhar Nori
2013-03-08 9:45 ` Prabhakar Lad
[not found] ` <CA+V-a8tSjF0Zz53_v=d-hUdKK4ihK_aLceOYnmQFhhKLOx3y1g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-03-08 9:51 ` Sekhar Nori [this message]
2013-01-28 13:47 ` [PATCH v2 5/6] ARM: davinci: da850: add OF_DEV_AUXDATA entry " Prabhakar Lad
2013-01-28 13:47 ` [PATCH v2 6/6] ARM: davinci: da850: configure system configuration chip(CFGCHIP3) for emac Prabhakar Lad
[not found] ` <1359380879-26306-7-git-send-email-prabhakar.lad-l0cyMroinI0@public.gmane.org>
2013-02-03 12:45 ` Sekhar Nori
2013-02-04 5:03 ` Prabhakar Lad
[not found] ` <CA+V-a8uE6jymk5Z14ydCmuoCAkcLM-ZJKpwp2-0CRXWQtXvTSA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-03-08 13:28 ` Prabhakar Lad
2013-02-04 5:28 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5139B4A5.2050404@ti.com \
--to=nsekhar-l0cymroini0@public$(echo .)gmane.org \
--cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public$(echo .)gmane.org \
--cc=hs-ynQEQJNshbs@public$(echo .)gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=prabhakar.csengg-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=prabhakar.lad-l0cyMroinI0@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox