From: Giuseppe CAVALLARO <peppe.cavallaro@st•com>
To: Richard Cochran <richardcochran@gmail•com>
Cc: netdev@vger•kernel.org, bh74.an@samsung•com,
Rayagond K <rayagond@vayavyalabs•com>
Subject: Re: [net-next.git 2/9] stmmac: add IEEE 1588-2002 PTP support
Date: Mon, 11 Mar 2013 07:35:36 +0100 [thread overview]
Message-ID: <513D7B38.1070404@st.com> (raw)
In-Reply-To: <20130310122553.GA6407@netboy.at.omicron.at>
On 3/10/2013 1:25 PM, Richard Cochran wrote:
> On Fri, Mar 08, 2013 at 08:02:21AM +0100, Giuseppe CAVALLARO wrote:
>> On 3/8/2013 7:34 AM, Richard Cochran wrote:
>
>>>> +
>>>> +static int enh_desc_get_rx_timestamp_status(struct dma_desc *p)
>>>> +{
>>>> + /* FIXME if Enhance descriptor with 8 DWORDS is enabled */
>>>
>>> Why not fix these FIXMEs for the next respin?
>>
>> This is fixed in the patch #5 where we use the extended descriptors
>> for PTP2.
>
> If possible, it is nice for the reviewers and for the logic of the
> patch series to order the changes so that these FIXMEs go away.
>
>>>> + struct hwtstamp_config config;
>>>> + struct timespec now;
>>>> + u64 temp = 0;
>>>
>>> You add this new code here, but you change it all around again a few
>>> patches later. Please just submit the final, combined version.
>>
>> we kept these separately because the patch #5 (for example) depends on
>> another one that adds the extended descriptor support. Also If I add
>> all the code in a single patch this will be very big. I had some
>> problems to review all separately. So I suspect that if we merge all
>> in a single patch this will not help (especially myself). At any rate,
>> tell me if you prefer to have a single patch. I can do that.
>
> I am not asking for bigger patches. It is good to arrange your patches
> in small steps, since that makes both reviewing and bisecting easier.
I tried to do that :-(
>
> However, for brand new code, I find it quite annoying to read one
> patch, and then to have it all re-written in the next one. (If a new
> function *only* grows during a patch series, that is easy to follow.)
>
> So what I would like to see is a logical, understandable series of
> small steps, but when new code appears, it is the real, final form.
Ok, I'll try to better re-organize the patches in the next version.
Thx a lot
Peppe
>
> Thanks,
> Richard
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-03-11 9:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 10:50 [net-next.git 0/9] stmmac: update to March_2013 (adding PTP & RGMII/SGMII) Giuseppe CAVALLARO
2013-03-07 10:50 ` [net-next.git 1/9] stmmac: add tx_skbuff_dma to save descriptors used by PTP Giuseppe CAVALLARO
2013-03-07 10:50 ` [net-next.git 2/9] stmmac: add IEEE 1588-2002 PTP support Giuseppe CAVALLARO
2013-03-08 6:34 ` Richard Cochran
2013-03-08 7:02 ` Giuseppe CAVALLARO
2013-03-08 7:51 ` Rayagond K
2013-03-10 12:25 ` Richard Cochran
2013-03-10 12:40 ` Richard Cochran
2013-03-11 6:35 ` Giuseppe CAVALLARO [this message]
[not found] ` <CAJ3bTp6tQ4L0vya9-eO0E+19Wk74uNJonbA9hqc+fgN77dcjOQ@mail.gmail.com>
2013-03-10 12:31 ` Richard Cochran
2013-03-07 10:50 ` [net-next.git 3/9] stmmac: support extend descriptors Giuseppe CAVALLARO
2013-03-07 10:50 ` [net-next.git 4/9] stmmac: add the support for PTP hw clock driver Giuseppe CAVALLARO
2013-03-10 12:10 ` Richard Cochran
[not found] ` <CAJ3bTp7n-Y6TYrhDMe58fALtX5O34qifO9khWYXpo-OwnrRKiQ@mail.gmail.com>
2013-03-11 18:55 ` Richard Cochran
2013-03-12 4:43 ` Rayagond K
2013-03-07 10:50 ` [net-next.git 5/9] stmmac: add IEEE 1588-2008 PTP V2 support Giuseppe CAVALLARO
2013-03-07 10:50 ` [net-next.git 6/9] stmmac: add missing supported filters to get_ts_info Giuseppe CAVALLARO
2013-03-10 12:36 ` Richard Cochran
2013-03-11 6:39 ` Giuseppe CAVALLARO
2013-03-07 10:50 ` [net-next.git 7/9] stmmac: start adding pcs and rgmii core irq Giuseppe CAVALLARO
2013-03-07 10:50 ` [net-next.git 8/9] stmmac: initial support to manage pcs modes Giuseppe CAVALLARO
2013-03-07 10:50 ` [net-next.git 9/9] stmmac: update the Doc and Version (PTP+SGMII) Giuseppe CAVALLARO
2013-03-07 20:34 ` [net-next.git 0/9] stmmac: update to March_2013 (adding PTP & RGMII/SGMII) David Miller
2013-03-08 7:16 ` Giuseppe CAVALLARO
2013-03-08 16:22 ` David Miller
2013-03-11 7:11 ` Giuseppe CAVALLARO
2013-03-22 14:27 ` Giuseppe CAVALLARO
2013-03-08 6:04 ` Richard Cochran
2013-03-08 6:39 ` Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513D7B38.1070404@st.com \
--to=peppe.cavallaro@st$(echo .)com \
--cc=bh74.an@samsung$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rayagond@vayavyalabs$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox