From: Florian Fainelli <florian@openwrt•org>
To: Michael Stapelberg <michael@stapelberg•de>
Cc: netdev@vger•kernel.org,
Lennert Buytenhek <buytenh@wantstofly•org>,
Andrew Lunn <andrew@lunn•ch>,
Thomas Petazzoni <thomas.petazzoni@free-electrons•com>
Subject: Re: [PATCH net-next 1/2] phy: add set_wol/get_wol functions
Date: Tue, 12 Mar 2013 11:54:45 +0100 [thread overview]
Message-ID: <513F0975.7020801@openwrt.org> (raw)
In-Reply-To: <1363046205-17239-1-git-send-email-michael@stapelberg.de>
Hello Michael,
This is looking good from my perspective, just a minor nitpick with
repsect to your comment below.
On 03/12/2013 12:56 AM, Michael Stapelberg wrote:
> This allows ethernet drivers (such as the mv643xx_eth) to support
> Wake on LAN on platforms where PHY registers have to be configured
> for Wake on LAN (e.g. the Marvell Kirkwood based qnap TS-119P II).
>
> Signed-off-by: Michael Stapelberg <michael@stapelberg•de>
> ---
> drivers/net/phy/phy.c | 16 ++++++++++++++++
> include/linux/phy.h | 10 ++++++++++
> 2 files changed, 26 insertions(+)
>
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index ef9ea92..298b4c2 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -1188,3 +1188,19 @@ int phy_ethtool_set_eee(struct phy_device *phydev, struct ethtool_eee *data)
> return 0;
> }
> EXPORT_SYMBOL(phy_ethtool_set_eee);
> +
> +int phy_ethtool_set_wol(struct phy_device *phydev, struct ethtool_wolinfo *wol)
> +{
> + if (phydev->drv->set_wol)
> + return phydev->drv->set_wol(phydev, wol);
> +
> + return -EOPNOTSUPP;
> +}
> +EXPORT_SYMBOL(phy_ethtool_set_wol);
> +
> +void phy_ethtool_get_wol(struct phy_device *phydev, struct ethtool_wolinfo *wol)
> +{
> + if (phydev->drv->get_wol)
> + phydev->drv->get_wol(phydev, wol);
> +}
> +EXPORT_SYMBOL(phy_ethtool_get_wol);
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 33999ad..9e11039 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -455,6 +455,14 @@ struct phy_driver {
> */
> void (*txtstamp)(struct phy_device *dev, struct sk_buff *skb, int type);
>
> + /* Some devices (e.g. qnap TS-119P II) require PHY register changes to
> + * enable Wake on LAN, so set_wol is provided to be called in the
> + * ethernet driver's set_wol function. */
I would just mention here that some PHY chip needs to be configured to
enable WoL at the PHY level (such as the Marvell 88E1318S PHY).
> + int (*set_wol)(struct phy_device *dev, struct ethtool_wolinfo *wol);
> +
> + /* See set_wol, but for checking whether Wake on LAN is enabled. */
> + void (*get_wol)(struct phy_device *dev, struct ethtool_wolinfo *wol);
> +
> struct device_driver driver;
> };
> #define to_phy_driver(d) container_of(d, struct phy_driver, driver)
> @@ -560,6 +568,8 @@ int phy_init_eee(struct phy_device *phydev, bool clk_stop_enable);
> int phy_get_eee_err(struct phy_device *phydev);
> int phy_ethtool_set_eee(struct phy_device *phydev, struct ethtool_eee *data);
> int phy_ethtool_get_eee(struct phy_device *phydev, struct ethtool_eee *data);
> +int phy_ethtool_set_wol(struct phy_device *phydev, struct ethtool_wolinfo *wol);
> +void phy_ethtool_get_wol(struct phy_device *phydev, struct ethtool_wolinfo *wol);
>
> int __init mdio_bus_init(void);
> void mdio_bus_exit(void);
>
next prev parent reply other threads:[~2013-03-12 10:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 23:56 [PATCH net-next 1/2] phy: add set_wol/get_wol functions Michael Stapelberg
2013-03-11 23:56 ` [PATCH net-next 2/2] mv643xx_eth with 88E1318S: support Wake on LAN Michael Stapelberg
2013-03-12 15:41 ` David Miller
2013-03-12 10:54 ` Florian Fainelli [this message]
2013-03-12 15:41 ` [PATCH net-next 1/2] phy: add set_wol/get_wol functions David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513F0975.7020801@openwrt.org \
--to=florian@openwrt$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=buytenh@wantstofly$(echo .)org \
--cc=michael@stapelberg$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=thomas.petazzoni@free-electrons$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox