From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: Andreas Henriksson <andreas@fatal•se>
Cc: shemminger@vyatta•com, netdev@vger•kernel.org
Subject: Re: [iproute2] Fix -oneline output when alias present
Date: Wed, 13 Mar 2013 05:20:08 -0700 [thread overview]
Message-ID: <51406EF8.5000506@cumulusnetworks.com> (raw)
In-Reply-To: <20130313094859.GA3097@amd64.fatal.se>
On 3/13/13 2:48 AM, Andreas Henriksson wrote:
> Hi!
>
> Just wanted to point out some minor style issues with your patch.
> See below...
>
> On Tue, Mar 12, 2013 at 12:03:47PM -0000, roopa@cumulusnetworks•com wrote:
> [...]
>> - if (do_link&& tb[IFLA_IFALIAS])
>> - fprintf(fp,"\n alias %s",
>> + if (do_link&& tb[IFLA_IFALIAS]) {
>> + fprintf(fp, "%s", _SL_);
>> + fprintf(fp," alias %s",
>
> ^^^ missing space here.
Oh, I hadn't noticed that. I did not introduce the style problem there.
I just happened to pick the _SL_line from else where in the code.
Since this patch is in, I will submit a patch to fix the spacing.
>
> Also, why not use a single fprintf?
I was just following convention here. The SL line seems to be on a line
of its own else where in the code. Which i did think was cleaner.
Thanks.
prev parent reply other threads:[~2013-03-13 12:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 22:03 [PATCH iproute2] Fix -oneline output when alias present roopa
2013-03-13 9:48 ` [iproute2] " Andreas Henriksson
2013-03-13 12:20 ` Roopa Prabhu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51406EF8.5000506@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=andreas@fatal$(echo .)se \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox