Subject: Re: [PATCH net-next 1/4] bridge: Add sysfs interface to control promisc mode

From: Vlad Yasevich <[email-masked]>
Date: Wed, 13 Mar 2013 11:44:25 -0400

On 03/13/2013 11:38 AM, Stephen Hemminger wrote:
> On Tue, 12 Mar 2013 21:45:23 -0400
> Vlad Yasevich <[email-masked]> wrote:
>
>> Add an sysfs interface to turn promiscusous mode on and off on
>> the bridge.  By default all interfaces in the bridge
>> are in promisc mode.  When promisc mode is turned off, it is
>> turned off on all bridge ports and the bridge turns on IFF_ALLMULTI
>> to handle multicast traffic.
>>
>> Signed-off-by: Vlad Yasevich <[email-masked]>
>> ---
>>   net/bridge/br_device.c   |   41 +++++++++++++++++++++++++++++++++++++++++
>>   net/bridge/br_if.c       |   22 +++++++++++++++++-----
>>   net/bridge/br_private.h  |    2 ++
>>   net/bridge/br_sysfs_br.c |   17 +++++++++++++++++
>>   4 files changed, 77 insertions(+), 5 deletions(-)
>>
>
> All attribute changes must also be available through netlink, and changes
> to attributes should cause a notification to applications listening for
> netlink events on that bridge.
>

There is currently no attribute for promisc vs non-promisc in the 
bridge.  Are you suggesting that this patch should add one?

-vlad