Subject: Re: [PATCH] drivers/isdn: break out of the loop after call isdn_tty_send_msg

From: Chen Gang <[email-masked]>
Date: Wed, 20 Mar 2013 13:03:50 +0800

Hello Maintainers:

  did I send incorrect mail address ?
    ./scripts/get_maintainers.pl leads to cc netdev, but exclude David Miller.
    is it a bug of ./scripts/get_maintainers.pl ?
      (this time, I include him in this mail address).

  welcome any members to providing suggestions or completions.

  thanks.

gchen.

On 2013年03月15日 10:02, Chen Gang wrote:
> Hello Maintainers:
> 
>   is it qualified to be applied ?
> 
>   thanks.
> 
> 
> 于 2013年02月28日 17:54, Jiri Slaby 写道:
>> On 02/28/2013 03:57 AM, Chen Gang wrote:
>>>
>>>   need break out of the loop after call isdn_tty_send_msg.
>>>     isdn_tty_send_msg is intended to eat the rest of the string.
>>>     so need not scan again the string which appended "+M...".
>>
>> Yes, looks good.
>>
>>> Signed-off-by: Chen Gang <[email-masked]>
>>> ---
>>>  drivers/isdn/i4l/isdn_tty.c |    4 +++-
>>>  1 files changed, 3 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/isdn/i4l/isdn_tty.c b/drivers/isdn/i4l/isdn_tty.c
>>> index d8a7d83..8ac7b33 100644
>>> --- a/drivers/isdn/i4l/isdn_tty.c
>>> +++ b/drivers/isdn/i4l/isdn_tty.c
>>> @@ -3587,7 +3587,7 @@ isdn_tty_parse_at(modem_info *info)
>>>  			case 'M':	/* MESSAGE */
>>>  				p++;
>>>  				isdn_tty_send_msg(info, m, p);
>>> -				break;
>>> +				goto tail;
>>>  			default:
>>>  				PARSE_ERROR;
>>>  			}
>>> @@ -3601,6 +3601,8 @@ isdn_tty_parse_at(modem_info *info)
>>>  			PARSE_ERROR;
>>>  		}
>>>  	}
>>> +
>>> +tail:
>>>  #ifdef CONFIG_ISDN_AUDIO
>>>  	if (!info->vonline)
>>>  #endif
>>>
>>
>>
> 
> 

-- 
Chen Gang

Asianux Corporation