From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, nobuhiro.iwamatsu.yj@renesas•com
Subject: Re: [PATCH v2 3/3] sh_eth: use managed device API
Date: Fri, 22 Mar 2013 01:43:54 +0300 [thread overview]
Message-ID: <514B8D2A.2090408@cogentembedded.com> (raw)
In-Reply-To: <20130321.173523.2134000966916487176.davem@davemloft.net>
Hello.
On 03/22/2013 12:35 AM, David Miller wrote:
>
>> Switch the driver to the managed device API by replacing ioremap() calls with
>> devm_ioremap_resource() (which will also result in calling request_mem_region()
>> which the driver forgot to do until now) and k[mz]alloc() with devm_kzalloc() --
>> this permits to simplify driver's probe()/remove() method cleanup. We can now
>> remove the ioremap() error messages since the error messages are printed by
>> devm_ioremap_resource() itself. We can also remove the 'bitbang' field from
>> 'struct sh_eth_private' as we don't need it anymore in order to free the memory
>> behind it...
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
>>
>> ---
>> Changes since initial posting:
>> - removed unused 'mdp' variable in sh_eth_drv_remove().
>>
>> Sorry, I seem to have missed the unused variable warning... :-/
> I already applied your original patch.
Thanks, you're really quick. Maybe too quick. :-)
> Please read your email before posting new versions of patches.
I'm monitoring my mail constantly but was just somewhat carried away
by testing a new patch when I suddenly saw the warning and went on to
fix it immediately. Unfortunately, it was already too late. :-(
> You have to send me a relative fix since your patches are applied
> already.
Will send in a jiffy...
WBR, Sergei
prev parent reply other threads:[~2013-03-21 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 22:35 [PATCH v2 3/3] sh_eth: use managed device API Sergei Shtylyov
2013-03-21 21:35 ` David Miller
2013-03-21 22:43 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514B8D2A.2090408@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox