From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Hong Zhiguo <honkiko@gmail•com>
Cc: netdev@vger•kernel.org, bridge@lists•linux-foundation.org,
davem@davemloft•net, stephen@networkplumber•org,
herbert@gondor•hengli.com.au, zhiguo.hong@emc•com
Subject: Re: [PATCH net-next] bridge: avoid br_ifinfo_notify when nothing changed
Date: Sun, 24 Mar 2013 17:34:47 +0300 [thread overview]
Message-ID: <514F0F07.9050702@cogentembedded.com> (raw)
In-Reply-To: <1364131607-11698-1-git-send-email-honkiko@gmail.com>
Hello.
On 03/24/2013 04:26 PM, Hong Zhiguo wrote:
> When neither IFF_BRIDGE nor IFF_BRIDGE_PORT is set,
> and afspec == NULL but protinfo != NULL, we run into
> "if (err == 0) br_ifinfo_notify(RTM_NEWLINK, p);" with
> random value in ret.
>
> Thanks to Sergei for pointing out the error in commit comments.
>
> Signed-off-by: Hong Zhiguo <honkiko@gmail•com>
For the future, if you post the revised version of the patch, you
should indicate in the subject it like this: [PATCH v2].
WBR, Sergei
next prev parent reply other threads:[~2013-03-24 13:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-23 5:14 [PATCH net-next] bridge: avoid br_ifinfo_notify when nothing changed Hong Zhiguo
2013-03-23 15:06 ` Sergei Shtylyov
2013-03-24 13:26 ` Hong Zhiguo
2013-03-24 14:34 ` Sergei Shtylyov [this message]
2013-03-24 21:15 ` David Miller
2013-03-25 15:32 ` Sergei Shtylyov
2013-03-25 16:08 ` David Miller
2013-03-25 16:31 ` Sergei Shtylyov
2013-03-24 21:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514F0F07.9050702@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=davem@davemloft$(echo .)net \
--cc=herbert@gondor$(echo .)hengli.com.au \
--cc=honkiko@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
--cc=zhiguo.hong@emc$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox