From: Alan Ott <alan@signal11•us>
To: "David S. Miller" <davem@davemloft•net>
Cc: Tony Cheneau <tony.cheneau@amnesiak•org>,
Eric Dumazet <eric.dumazet@gmail•com>,
Alexander Smirnov <alex.bluesman.smirnov@gmail•com>,
netdev@vger•kernel.org, linux-zigbee-devel@lists•sourceforge.net
Subject: Re: [PATCH v2 net-next 00/12] 6lowpan: Some more bug fixes
Date: Tue, 26 Mar 2013 07:48:17 -0400 [thread overview]
Message-ID: <51518B01.9060309@signal11.us> (raw)
In-Reply-To: <1364270372-19430-1-git-send-email-tony.cheneau@amnesiak.org>
On 03/25/2013 11:59 PM, Tony Cheneau wrote:
> This patchset fixes serious bugs within the 6LoWPAN modules. I wrote a script
> (available at [1]) to prove the issues are real. One can try and see that
> without these patches, most of the test fail (e.g. packet dropped by the
> receiver or node crashing). With all patches applied, all tests succeed. The
> tests themselves are very basic: sending ICMP packets, sending UDP packets,
> sending TCP packets, varying size of the packets. This actually triggers some
> 6LoWPAN specific code, namely fragmentation, packet reassembly and header
> compression.
>
> This code passed the checkpatch.pl tool with a few warnings, that I believe
> are OK. It should apply cleanly on the latest net-next.
>
I and have been running some form of this patchset since October, and
have reviewed it several times.
Reviewed-by: Alan Ott <alan@signal11•us>
Tested-by: Alan Ott <alan@signal11•us>
> Regards,
> Tony Cheneau
>
> [1]: https://github.com/tcheneau/linux802154-regression-tests
>
> Tony Cheneau (12):
> 6lowpan: lowpan_is_iid_16_bit_compressable() does not detect
> compressible address correctly
> 6lowpan: next header is not properly set upon decompression of a UDP
> header.
> 6lowpan: always enable link-layer acknowledgments
> mac802154: turn on ACK when enabled by the upper layers
> 6lowpan: use short IEEE 802.15.4 addresses for broadcast destination
> 6lowpan: fix first fragment (FRAG1) handling
> 6lowpan: add debug messages for 6LoWPAN fragmentation
> 6lowpan: store fragment tag values per device instead of net stack
> wide
> mac802154: re-introduce mac802154_dev_get_dsn()
> 6lowpan: obtain IEEE802.15.4 sequence number from the MAC layer
> 6lowpan: use the PANID provided by the device instead of a static
> value
> 6lowpan: modify udp compression/uncompression to match the standard
>
> net/ieee802154/6lowpan.c | 136 +++++++++++++++++++++++++++++++++++++---------
> net/ieee802154/6lowpan.h | 7 ++-
> net/mac802154/mac802154.h | 1 +
> net/mac802154/mac_cmd.c | 1 +
> net/mac802154/mib.c | 9 +++
> net/mac802154/wpan.c | 2 +
> 6 files changed, 127 insertions(+), 29 deletions(-)
>
next prev parent reply other threads:[~2013-03-26 11:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 3:59 [PATCH v2 net-next 00/12] 6lowpan: Some more bug fixes Tony Cheneau
[not found] ` <1364270372-19430-1-git-send-email-tony.cheneau-jNfjcPZKvDhg9hUCZPvPmw@public.gmane.org>
2013-03-26 3:59 ` [PATCH v2 net-next 01/12] 6lowpan: lowpan_is_iid_16_bit_compressable() does not detect compressible address correctly Tony Cheneau
2013-03-26 3:59 ` [PATCH v2 net-next 02/12] 6lowpan: next header is not properly set upon decompression of a UDP header Tony Cheneau
2013-03-26 3:59 ` [PATCH v2 net-next 03/12] 6lowpan: always enable link-layer acknowledgments Tony Cheneau
2013-03-26 3:59 ` [PATCH v2 net-next 04/12] mac802154: turn on ACK when enabled by the upper layers Tony Cheneau
2013-03-26 3:59 ` [PATCH v2 net-next 05/12] 6lowpan: use short IEEE 802.15.4 addresses for broadcast destination Tony Cheneau
2013-03-26 11:56 ` [Linux-zigbee-devel] " Alexander Aring
2013-03-26 3:59 ` [PATCH v2 net-next 06/12] 6lowpan: fix first fragment (FRAG1) handling Tony Cheneau
2013-03-26 3:59 ` [PATCH v2 net-next 07/12] 6lowpan: add debug messages for 6LoWPAN fragmentation Tony Cheneau
2013-03-26 3:59 ` [PATCH v2 net-next 08/12] 6lowpan: store fragment tag values per device instead of net stack wide Tony Cheneau
2013-03-26 12:38 ` Sergei Shtylyov
2013-03-26 3:59 ` [PATCH v2 net-next 09/12] mac802154: add mac802154_dev_get_dsn() Tony Cheneau
2013-03-26 3:59 ` [PATCH v2 net-next 10/12] 6lowpan: obtain IEEE802.15.4 sequence number from the MAC layer Tony Cheneau
2013-03-26 3:59 ` [PATCH v2 net-next 11/12] 6lowpan: use the PANID provided by the device instead of a static value Tony Cheneau
2013-03-26 3:59 ` [PATCH v2 net-next 12/12] 6lowpan: modify udp compression/uncompression to match the standard Tony Cheneau
2013-03-26 11:48 ` Alan Ott [this message]
2013-03-26 16:39 ` [PATCH v2 net-next 00/12] 6lowpan: Some more bug fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51518B01.9060309@signal11.us \
--to=alan@signal11$(echo .)us \
--cc=alex.bluesman.smirnov@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=linux-zigbee-devel@lists$(echo .)sourceforge.net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tony.cheneau@amnesiak$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox