From: Chen Gang <gang.chen@asianux•com>
To: David Miller <davem@davemloft•net>
Cc: edumazet@google•com, dborkman@redhat•com, wad@chromium•org,
eparis@redhat•com, netdev@vger•kernel.org
Subject: Re: [PATCH v2] include/linux: printk is needed in filter.h when CONFIG_BPF_JIT is defined
Date: Sat, 30 Mar 2013 11:10:55 +0800 [thread overview]
Message-ID: <515657BF.7010101@asianux.com> (raw)
In-Reply-To: <20130329.153447.426374969178935845.davem@davemloft.net>
On 2013年03月30日 03:34, David Miller wrote:
> From: Chen Gang <gang.chen@asianux•com>
> Date: Fri, 29 Mar 2013 09:24:53 +0800
>
>> >
>> > for make V=1 EXTRA_CFLAGS=-W ARCH=arm allmodconfig
>> > printk is need when CONFIG_BPF_JIT is defined
>> > or it will report pr_err and print_hex_dump are implicit declaration
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux•com>
> There are no references to pr_err nor print_hex_dump in this
> filter.h header file.
maybe we see the different tree.
I find it in next-20130328.
please help check, thanks.
commit 79617801ea0c0e6664cb497d4c1892c2ff407364
Author: Daniel Borkmann <dborkman@redhat•com>
Date: Thu Mar 21 22:22:03 2013 +0100
filter: bpf_jit_comp: refactor and unify BPF JIT image dump output
If bpf_jit_enable > 1, then we dump the emitted JIT compiled image
after creation. Currently, only SPARC and PowerPC has similar output
as in the reference implementation on x86_64. Make a small helper
function in order to reduce duplicated code and make the dump output
uniform across architectures x86_64, SPARC, PPC, ARM (e.g. on ARM
flen, pass and proglen are currently not shown, but would be
interesting to know as well), also for future BPF JIT implementations
on other archs.
Cc: Mircea Gherzan <mgherzan@gmail•com>
Cc: Matt Evans <matt@ozlabs•org>
Cc: Eric Dumazet <eric.dumazet@google•com>
Cc: David S. Miller <davem@davemloft•net>
Signed-off-by: Daniel Borkmann <dborkman@redhat•com>
Signed-off-by: David S. Miller <davem@davemloft•net>
diff --git a/include/linux/filter.h b/include/linux/filter.h
index d2059cb..d7d2508 100644
--- a/include/linux/filter.h
+++ b/include/linux/filter.h
@@ -50,6 +50,16 @@ extern int sk_get_filter(struct sock *sk, struct sock_filter __user *filter, uns
#ifdef CONFIG_BPF_JIT
extern void bpf_jit_compile(struct sk_filter *fp);
extern void bpf_jit_free(struct sk_filter *fp);
+
+static inline void bpf_jit_dump(unsigned int flen, unsigned int proglen,
+ u32 pass, void *image)
+{
+ pr_err("flen=%u proglen=%u pass=%u image=%p\n",
+ flen, proglen, pass, image);
+ if (image)
+ print_hex_dump(KERN_ERR, "JIT code: ", DUMP_PREFIX_ADDRESS,
+ 16, 1, image, proglen, false);
+}
#define SK_RUN_FILTER(FILTER, SKB) (*FILTER->bpf_func)(SKB, FILTER->insns)
#else
static inline void bpf_jit_compile(struct sk_filter *fp)
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-03-30 3:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5153DC24.4010104@asianux.com>
2013-03-29 1:24 ` [PATCH v2] include/linux: printk is needed in filter.h when CONFIG_BPF_JIT is defined Chen Gang
2013-03-29 19:34 ` David Miller
2013-03-30 3:10 ` Chen Gang [this message]
2013-03-30 3:32 ` David Miller
2013-03-30 3:41 ` Chen Gang
2013-03-30 3:17 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515657BF.7010101@asianux.com \
--to=gang.chen@asianux$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dborkman@redhat$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=eparis@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=wad@chromium$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox