Subject: Re: [Suggestion] drivers/isdn/divert: break looping, or memory leak by calling kmalloc again

From: Tilman Schmidt <[email-masked]>
Date: Mon, 01 Apr 2013 12:08:26 +0200

Am 01.04.2013 04:11, schrieb Chen Gang:
> in drivers/isdn/divert/isdn_divert.c:
> 
>   in 'for' looping (line 395..515)
>     the 'cs' may call kmalloc again (line 453).
> 
>   it seems need break looping, when get valid 'cs' value (line 509)

I don't think so. If the kmalloc for cs succeeds, control flow will
continue linearly up to the 'if' statement in line 503. Then it will
either kfree(cs) and return, or reach the 'break' in line 514 which
will end the 'for' loop.

HTH
Tilman

-- 
Tilman Schmidt                    E-Mail: [email-masked]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)