Subject: Re: [PATCH] drivers/isdn/divert: beautify code, delete useless 'break'

From: Sergei Shtylyov <[email-masked]>
Date: Mon, 01 Apr 2013 18:04:17 +0400

Hello.

On 01-04-2013 5:52, Chen Gang wrote:

>    delete useless break statements.

> Signed-off-by: Chen Gang <[email-masked]>
> ---
>   drivers/isdn/divert/isdn_divert.c |    2 --
>   1 files changed, 0 insertions(+), 2 deletions(-)

> diff --git a/drivers/isdn/divert/isdn_divert.c b/drivers/isdn/divert/isdn_divert.c
> index db432e6..76d505e 100644
> --- a/drivers/isdn/divert/isdn_divert.c
> +++ b/drivers/isdn/divert/isdn_divert.c
> @@ -442,7 +442,6 @@ static int isdn_divert_icall(isdn_ctrl *ic)
>   		switch (dv->rule.action) {
>   		case DEFLECT_IGNORE:
>   			return (0);
> -			break;
>
>   		case DEFLECT_ALERT:
>   		case DEFLECT_PROCEED:
> @@ -511,7 +510,6 @@ static int isdn_divert_icall(isdn_ctrl *ic)
>
>   		default:
>   			return (0); /* ignore call */
> -			break;

    You could have removed stupid () around 0, while at it.

WBR, Sergei