Subject: Re: [PATCH] drivers/isdn/divert: beautify code, delete useless 'break'

From: Chen Gang <[email-masked]>
Date: Tue, 02 Apr 2013 08:44:29 +0800

On 2013年04月01日 22:04, Sergei Shtylyov wrote:
> 
>> diff --git a/drivers/isdn/divert/isdn_divert.c
>> b/drivers/isdn/divert/isdn_divert.c
>> index db432e6..76d505e 100644
>> --- a/drivers/isdn/divert/isdn_divert.c
>> +++ b/drivers/isdn/divert/isdn_divert.c
>> @@ -442,7 +442,6 @@ static int isdn_divert_icall(isdn_ctrl *ic)
>>           switch (dv->rule.action) {
>>           case DEFLECT_IGNORE:
>>               return (0);
>> -            break;
>>
>>           case DEFLECT_ALERT:
>>           case DEFLECT_PROCEED:
>> @@ -511,7 +510,6 @@ static int isdn_divert_icall(isdn_ctrl *ic)
>>
>>           default:
>>               return (0); /* ignore call */
>> -            break;
> 
>    You could have removed stupid () around 0, while at it.

  oh, really, I should do it.

  I will send patch v2 for it

  thanks.

  :-)

-- 
Chen Gang

Asianux Corporation