From: Florian Fainelli <florian-p3rKhJxN3npAfugRpC6u6w@public•gmane.org>
To: Florian Fainelli <florian-p3rKhJxN3npAfugRpC6u6w@public•gmane.org>
Cc: moinejf-GANU6spQydw@public•gmane.org,
jason-NLaQJdtUoK4Be96aLqz0jA@public•gmane.org,
andrew-g2DYL2Zd6BY@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public•gmane.org,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public•gmane.org,
buytenh-OLH4Qvv75CYX/NnBR394Jw@public•gmane.org,
jm-Pj/HzkgeCk7QXOPxS62xeg@public•gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public•gmane.org,
sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org
Subject: Re: [PATCH 2/4] ARM: kirkwood: add device node entries for the gigabit interfaces
Date: Wed, 03 Apr 2013 11:27:02 +0200 [thread overview]
Message-ID: <515BF5E6.5040703@openwrt.org> (raw)
In-Reply-To: <1364580879-4297-3-git-send-email-florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
Le 03/29/13 19:14, Florian Fainelli a écrit :
> This patch modifies kirkwood.dtsi to specify the various gigabit
> interfaces nodes available on kirkwood devices. They are disabled by
> default and should be enabled on a per-board basis. egiga0 and egiga1
> aliases are defined for convenience. The mdio node is also present and
> should be enabled on a per-board basis as well.
>
> Signed-off-by: Florian Fainelli <florian@openwrt•org>
> ---
[snip]
> +
> + ethernet-group@70000 {
This one is off-by 0x2000 and should have been 72000
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "marvell,mv643xx-eth-block";
> + reg = <0x70000 0x4000>;
Same here
> + tx-csum-limit = <1600>;
> + status = "disabled";
> +
> + egiga0: egiga0@0 {
> + device_type = "network";
> + compatible = "marvell,mv643xx-eth";
> + reg = <0>;
> + interrupts = <11>;
> + clocks = <&gate_clk 0>;
> + clock-names = "0";
> + };
> + };
> +
> + ethernet-group@74000 {
And here, it should be 76000
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "marvell,mv643xx-eth-block";
> + reg = <0x74000 0x4000>;
And here too.
--
Florian
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists•ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
next prev parent reply other threads:[~2013-04-03 9:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 18:14 [PATCH 0/4] mv643xx_eth device tree bindings Florian Fainelli
2013-03-29 18:14 ` [PATCH 1/4] mv643xx_eth: add Device Tree bindings Florian Fainelli
2013-03-29 18:25 ` Florian Fainelli
2013-03-29 18:14 ` [PATCH 2/4] ARM: kirkwood: add device node entries for the gigabit interfaces Florian Fainelli
[not found] ` <1364580879-4297-3-git-send-email-florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2013-03-29 18:48 ` Jason Cooper
2013-03-29 18:51 ` Florian Fainelli
2013-04-03 9:27 ` Florian Fainelli [this message]
2013-03-29 18:14 ` [PATCH 3/4] ARM: orion5x: add gigabit ethernet device tree node Florian Fainelli
2013-03-29 18:14 ` [PATCH 4/4] ARM: dove: add gigabit device tree nodes to dove.dtsi Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515BF5E6.5040703@openwrt.org \
--to=florian-p3rkhjxn3npafugrpc6u6w@public$(echo .)gmane.org \
--cc=andrew-g2DYL2Zd6BY@public$(echo .)gmane.org \
--cc=buytenh-OLH4Qvv75CYX/NnBR394Jw@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public$(echo .)gmane.org \
--cc=jason-NLaQJdtUoK4Be96aLqz0jA@public$(echo .)gmane.org \
--cc=jm-Pj/HzkgeCk7QXOPxS62xeg@public$(echo .)gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public$(echo .)gmane.org \
--cc=moinejf-GANU6spQydw@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public$(echo .)gmane.org \
--cc=sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox