Subject: Re: [Suggestion] ISDN: isdnloop: C grammar issue, '}' miss match 'if' and 'switch' statement.

From: Chen Gang <[email-masked]>
Date: Thu, 04 Apr 2013 17:05:23 +0800

On 2013年04月03日 22:08, Michal Kubecek wrote:
> On Wed, Apr 03, 2013 at 09:35:55PM +0800, Chen Gang wrote:
>> > 
>> > in drivers/isdn/isdnloop/isdnloop.c
>> > 
>> >   issue description:
>> >     it is in function 'isdnloop_command'.
>> >     it seems a C grammar issue for '}' miss match 'if' and 'switch' statement
>> >     please check the line 1243, 1265, 1341.
>> > 
>> >   building:
>> >     make allyesconfig, can not let it built.
>> >     in menuconfig, we (at least for me) can not let ISDN_DRV_LOOP = 'y' or 'm'.
>> >     is this module a waste module which should be deleted ?
>> > 
>> >   the related commit:
>> >     commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2
>> >     Author: Linus Torvalds <[email-masked]>
>> >     Date:   Sat Apr 16 15:20:36 2005 -0700
> As far as I can see, this rather comes from
> 
> commit 475be4d85a274d0961593db41cf85689db1d583c
> Author: Joe Perches <[email-masked]>
> Date:   Sun Feb 19 19:52:38 2012 -0800

  Joe Perches only beautified the code, not change the contents.

  please check thanks.

-- 
Chen Gang

Asianux Corporation