Subject: Re: [PATCH] net: mv643xx_eth: remove deprecated inet_lro support

From: Sebastian Hesselbarth <[email-masked]>
Date: Thu, 11 Apr 2013 21:52:52 +0200

On 04/11/2013 09:46 PM, Eric Dumazet wrote:
> On Thu, 2013-04-11 at 21:11 +0200, Sebastian Hesselbarth wrote:
>> With recent support for GRO, there is no need to keep both LRO and
>> GRO. This patch therefore removes the deprecated inet_lro support
>> from mv643xx_eth. This is work is based on an experimental patch
>> provided by Eric Dumazet and Willy Tarreau.
>>
>> Signed-off-by: Sebastian Hesselbarth<[email-masked]>
>> Based-on-patch-by: Eric Dumazet<[email-masked]>
>> Based-on-patch-by: Willy Tarreau<[email-masked]>
>> ---
>> Note: This patch is based upon recent cleanup patches and GRO support
>> patch for mv643xx_eth.
>>
>> Cc: "David S. Miller"<[email-masked]>
>> Cc: Lennert Buytenhek<[email-masked]>
>> Cc: Andrew Lunn<[email-masked]>
>> Cc: Jason Cooper<[email-masked]>
>> Cc: Florian Fainelli<[email-masked]>
>> Cc: Benjamin Herrenschmidt<[email-masked]>
>> Cc: Paul Mackerras<[email-masked]>
>> Cc: Dale Farnsworth<[email-masked]>
>> Cc: Ben Hutchings<[email-masked]>
>> Cc: Soeren Moch<[email-masked]>
>> Cc: Eric Dumazet<[email-masked]>
>> Cc: Willy Tarreau<[email-masked]>
>> Cc: [email-masked]
>> Cc: [email-masked]
>> Cc: [email-masked]
>> Cc: [email-masked]
>> ---
>>   drivers/net/ethernet/marvell/mv643xx_eth.c |   97 +---------------------------
>>   1 file changed, 3 insertions(+), 94 deletions(-)
>
> Seems fine to me, but you also could remove "select INET_LRO"
> from drivers/net/ethernet/marvell/Kconfig

Ok, I will wait for tomorrow to see if there are more objections and
respin a v2.

Sebastian