public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Markus Niebel <list-09@tqsc•de>
To: Fabio Estevam <festevam@gmail•com>
Cc: Frank Li <Frank.Li@freescale•com>,
	netdev@vger•kernel.org, u.kleine-koenig@pengutronix•de,
	lznuaa@gmail•com, shawn.guo@linaro•org, davem@davemloft•net,
	linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v2 1/1 net] enet: fec: fix fail resume from suspend state
Date: Fri, 12 Apr 2013 17:32:33 +0200	[thread overview]
Message-ID: <51682911.2040100@tqsc.de> (raw)
In-Reply-To: <CAOMZO5A9Tc_n8OGgxxw0ZE9xGOPjsYvyqVZtjWwTRn9as3eKCw@mail.gmail.com>

Hello,

Am 12.04.2013 15:23, wrote Fabio Estevam:
> Hi Frank,
> 
> On Tue, Mar 26, 2013 at 11:12 PM, Frank Li <Frank.Li@freescale•com> wrote:
>> Without this patch
>> 1. boot with nfs (no_console_suspend)
>> 2. echo mem >/sys/power/state
>> 3. wakeup by wakesource
>> 4. print "eth0: tx queue full"
> 
> I still have issues with suspend/resume with your patch applied:
> 
> $ echo enabled >
> /sys/devices/80000000.apb/80040000.apbx/80074000.serial/tty/ttyAMA0/power/wakeup
> $ echo mem > /sys/power/state
> 
> [   31.577857] PM: Syncing filesystems ... done.
> [   31.604332] Freezing user space processes ... (elapsed 0.01 seconds) done.
> [   31.622160] Freezing remaining freezable tasks ... (elapsed 0.01 seconds) do.
> [   31.642018] Suspending console(s) (use no_console_suspend to debug)
> [   31.666914] PM: suspend of devices complete after 12.672 msecs
> [   31.671975] PM: late suspend of devices complete after 5.007 msecs
> [   31.678542] PM: noirq suspend of devices complete after 6.521 msecs
> [   31.682147] PM: noirq resume of devices complete after 3.186 msecs
> [   31.687396] PM: early resume of devices complete after 3.464 msecs
> [   31.759982] PM: resume of devices complete after 2432.562 msecs
> 
> (Then send any char via DUART to wakeup the system)
> 
> [   31.802673] Restarting tasks ... done.
> [   33.829493] libphy: 800f0000.etherne:00 - Link is Down
> [   36.859102] FEC: MDIO read timeout
> [   38.889180] FEC: MDIO read timeout
> 

Which clock is connected to the PHY? Is it the enet_clock generated by i.MX28? Is the connection between PHY and i.MX28 RMII?

If the FEC goes through a reset the clock generated by i.MX28 may switched to MII (25 MHz). Maybe the PHY gets confused if it is working in RMII mode.

> It does not fail 100%: there are times that suspend works just fine.
> 

  reply	other threads:[~2013-04-12 15:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27  2:12 [PATCH v2 1/1 net] enet: fec: fix fail resume from suspend state Frank Li
2013-03-27 18:09 ` David Miller
2013-04-12 13:23 ` Fabio Estevam
2013-04-12 15:32   ` Markus Niebel [this message]
2013-04-12 20:01     ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51682911.2040100@tqsc.de \
    --to=list-09@tqsc$(echo .)de \
    --cc=Frank.Li@freescale$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=festevam@gmail$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=lznuaa@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=shawn.guo@linaro$(echo .)org \
    --cc=u.kleine-koenig@pengutronix$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox