Subject: Re: [PATCH 1/2] genirq: add function to get IRQ edge/level flags

From: Stephen Warren <[email-masked]>
Date: Fri, 12 Apr 2013 15:56:32 -0600

On 04/12/2013 12:05 PM, Javier Martinez Canillas wrote:
...
> So, is better to add an irq_get_trigger_type() function to obtain
> the edge/level flags for an IRQ.

> diff --git a/include/linux/irq.h b/include/linux/irq.h

> +static inline u32 irq_get_trigger_type(unsigned int irq)
> +{
> +	struct irq_data *d = irq_get_irq_data(irq);
> +	return d ? d->state_use_accessors & IRQD_TRIGGER_MASK : 0;

Should the direct access to d->state_use_accessors be replaced with a
call to irqd_get_trigger_type()? Perhaps since this is inside the IRQ
code header, there's no need to use the accessor function?