Subject: Re: [PATCH 5/5] ks8851: Remove unneeded PM_OPS definitions

From: Lars-Peter Clausen <[email-masked]>
Date: Wed, 17 Apr 2013 08:27:55 +0200

On 04/16/2013 10:37 PM, David Miller wrote:
> From: Lars-Peter Clausen <[email-masked]>
> Date: Tue, 16 Apr 2013 22:29:37 +0200
> 
>> On 04/16/2013 09:28 PM, Fabio Estevam wrote:
>>> SIMPLE_DEV_PM_OPS macro can handle !CONFIG_PM_SLEEP case nicely, so there is no
>>> need to define PM_OPS for both CONFIG_PM_SLEEP and !CONFIG_PM_SLEEP cases.
>>>
>>> Remove the unneeded definitions.
>>>
>>> Cc: Lars-Peter Clausen <[email-masked]>
>>> Signed-off-by: Fabio Estevam <[email-masked]>
>>
>> yea, but now you have the dev_pm_ops struct, even if pm is disabled.
> 
> That's fine, it allows the functions to be compile tested in all
> configurations.

The functions are still protected by a #ifdef, it's just the dev_pm_ops struct
which is not anymore.

- Lars