Subject: Re: [PATCH] pkt_sched: fix error return code in fw_change_attrs()

From: Jamal Hadi Salim <[email-masked]>
Date: Thu, 18 Apr 2013 09:23:30 -0400

On 13-04-17 10:49 PM, Wei Yongjun wrote:
> From: Wei Yongjun <[email-masked]>
>
> Fix to return -EINVAL when tb[TCA_FW_MASK] is set and head->mask != 0xFFFFFFFF
> instead of 0 (ifdef CONFIG_NET_CLS_IND and tb[TCA_FW_INDEV]), as done elsewhere
> in this function.
>
> Signed-off-by: Wei Yongjun <[email-masked]>

Makes sense.  I think i would have said something like:
"dont use the err code from tcf_change_indev() in case it succeeds to 
report TCA_FW_MASK errors"

Signed-off-by: Jamal Hadi Salim <[email-masked]>

cheers,
jamal