Subject: Re: [PATCH v2 7/8] net: sh-eth: Remove ifdef for sh_eth_select_mii

From: Sergei Shtylyov <[email-masked]>
Date: Thu, 18 Apr 2013 18:36:45 +0400

Hello.

On 18-04-2013 14:11, Nobuhiro Iwamatsu wrote:

> Signed-off-by: Nobuhiro Iwamatsu <[email-masked]>

    That's what I was going to do first.

>   drivers/net/ethernet/renesas/sh_eth.c |    4 ----
>   1 file changed, 4 deletions(-)

> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index a4e337f..eb428d4 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -313,9 +313,6 @@ static const u16 sh_eth_offset_fast_sh3_sh2[SH_ETH_MAX_REGISTER_OFFSET] = {
>   	[TSU_ADRL31]	= 0x01fc,
>   };
>
> -#if defined(CONFIG_CPU_SUBTYPE_SH7734) || \
> -	defined(CONFIG_CPU_SUBTYPE_SH7763) || \
> -	defined(CONFIG_ARCH_R8A7740)
>   static void sh_eth_select_mii(struct net_device *ndev)

    Don't you want to annotate the function with __maybe_unused?

WBR, Sergei