Subject: Re: [PATCH 3/5] net/cpsw: don't rely on netif_running() to check which device is active

From: Mugunthan V N <[email-masked]>
Date: Fri, 19 Apr 2013 16:05:55 +0530

On 4/18/2013 5:40 PM, Sebastian Andrzej Siewior wrote:
> On 04/18/2013 01:50 PM, Mugunthan V N wrote:
>
>>> diff --git a/drivers/net/ethernet/ti/cpsw.c
>>> b/drivers/net/ethernet/ti/cpsw.c
>>> index 3b22a36..c32780d 100644
>>> --- a/drivers/net/ethernet/ti/cpsw.c
>>> +++ b/drivers/net/ethernet/ti/cpsw.c
>>> @@ -341,6 +341,7 @@ struct cpsw_priv {
>>>        int                host_port;
>>>        struct clk            *clk;
>>>        u8                mac_addr[ETH_ALEN];
>>> +    u8                active;
>> Frame work is providing this feature then why you need to have additional
>> book keeping in device private?
> Which function? I more than happy to use it.
>
The same netif_running(). But why you are telling not to rely on this API?
device state is updated immediately after successful ndo_open.

Regards
Mugunthan V N