Subject: Re: [PATCH net-next V2 1/5] net/mlx4_core: Add timestamping device capability

From: Sergei Shtylyov <[email-masked]>
Date: Mon, 22 Apr 2013 21:10:55 +0400

Hello.

On 04/22/2013 03:56 PM, Amir Vadai wrote:

> From: Eugenia Emantayev <[email-masked]>
>
> Add new device capability for timestamping support and query FW to retrieve it.
>
> Signed-off-by: Eugenia Emantayev <[email-masked]>
> Signed-off-by: Or Gerlitz <[email-masked]>
> Signed-off-by: Amir Vadai <[email-masked]>
> ---
>   drivers/net/ethernet/mellanox/mlx4/fw.c |    7 ++++++-
>   include/linux/mlx4/device.h             |    3 ++-
>   2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c
> index ab470d9..8f394be 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/fw.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c
> @@ -130,7 +130,8 @@ static void dump_dev_cap_flags2(struct mlx4_dev *dev, u64 flags)
>   		[1] = "RSS Toeplitz Hash Function support",
>   		[2] = "RSS XOR Hash Function support",
>   		[3] = "Device manage flow steering support",
> -		[4] = "Automatic mac reassignment support"
> +		[4] = "Automatic mac reassignment support",

    "MAC" perhaps? Although you're only adding a comma...

WBR, Sergei