Subject: Re: [PATCH v3] net: mac802154: comparision issue of type cast, finding by EXTRA_CFLAGS=-W

From: Chen Gang <[email-masked]>
Date: Thu, 25 Apr 2013 16:43:14 +0800

On 2013年04月25日 16:10, David Miller wrote:
> From: Chen Gang <[email-masked]>
> Date: Tue, 23 Apr 2013 19:24:36 +0800
> 
>> > 
>> > Need change ~(u8)0 to 0xff, or in mac802154_wpan_xmit(), "u8 chan"
>> > will never == MAC802154_CHAN_NONE.
>> > 
>> > The related warning:
>> >   net/mac802154/wpan.c:325:2: warning: comparison is always false
>> >   due to limited range of data type [-Wtype-limits]
>> > 
>> > The related unit test:
>> >   cc -Wall -O2 -o test test.c
>> >   ./test
>> >   will output 'different'
>> > 
>> >   (after use '0xff' instead of '~(u8)0', it will output 'equal')
>  ...
>> > Signed-off-by: Chen Gang <[email-masked]>
> This change belong in the 'net' tree, but your patch won't apply
> cleanly there as this part of the header file looks slightly
> different there.
> 
> Please respin your patch against 'net' and resubmit, thank you.
> 

Excuse me, my English is not quite well, I guess your meaning is: send
patch v4, and change the subject to "[PATCH v4] mac802154: comparision
issue of type cast, finding by EXTRA_CFLAGS=-W".

Is it correct ?

(the change is for net/mac802154/mac802154.h, and exist in v3.9-rc8)

Thanks.

-- 
Chen Gang

Asianux Corporation