Subject: Re: [net-next PATCH 1/3] drivers: of: add phy fixup support in DT

From: Mugunthan V N <[email-masked]>
Date: Thu, 25 Apr 2013 15:34:42 +0530

On 4/25/2013 1:26 PM, David Miller wrote:
> From: Mugunthan V N <[email-masked]>
> Date: Mon, 22 Apr 2013 23:50:36 +0530
>
>> In earlier case phy fixup are added in board file as this is no more the case
>> so adding support for phy register fixup in Device Tree
>>
>> Signed-off-by: Mugunthan V N <[email-masked]>
> When people put a series of undocumented PHY register writes using
> constants, we tell them it's firmware.
>
> If these PHY registers are actually documented in the driver, write a
> function in that driver which does the programming sequence, then add
> a property that the driver looks for in order to determine whether to
> call that sequence or not.
>
> I don't want people putting random PHY raw programming sequences and
> other crap like that into the OF device nodes.  It's extremely
> inelegant and inviting abuse.
>
Will modify the source as per your comments and will submit v2 patch set.

Regards
Mugunthan V N