From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Alexander Duyck <alexander.h.duyck@intel•com>
Cc: shemminger@vyatta•com, netdev@vger•kernel.org,
jeffrey.t.kirsher@intel•com, Hasan Chowdhury <shemonc@gmail•com>
Subject: Re: [IPROUTE PATCH] iproute2: act_ipt fix xtables breakage on older versions.
Date: Sun, 28 Apr 2013 10:31:10 -0400 [thread overview]
Message-ID: <517D32AE.503@mojatatu.com> (raw)
In-Reply-To: <517AA41C.4040205@intel.com>
Hi Alex,
On 13-04-26 11:58 AM, Alexander Duyck wrote:
> Getting it to compile is kind of important since it was preventing me
> from completing the build for iproute2 as I had another fix I needed to
> test.
So i just went back and looked. I was under the impression the original
patch from Hasan was not incorporated, it turns out it was (I just didnt
get the usual "applied" email; ands unfortunately for some reason i
showed up as the author instead of Hasan). It is the patch you are
referring to.
Second - I did compile this on Debian squeeze which is iptables 1.4.8
based; lucky, I still have that machine around, so i just verified again
that the current git tree compiles fine there.
So this could be a fedora specific issue.
What does the generated Config file have for you?
on squeeze:
IPT_LIB_DIR:=/lib/xtables
>
> If you have some test case you want me to run just let me know. All I
> did here is revert the changes that I believe were made incorrectly for
> versions prior to 1.4.10 in "iproute2: act_ipt fix xtables breakage".
> It states it was fixing it for versions starting in 1.4.10 which I am
> assuming is the XTABLES_VERSION_CODE >= 6 case so it should not have
> modified the 3 parameter case for versions prior to 6 which is what I
> corrected.
>
Are you sure about that? Please double check again, i see 4 parameters.
Having said that the mystery and breakages may have to do with the way
the different distros package iptables.
cheers,
jamal
next prev parent reply other threads:[~2013-04-28 14:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 22:07 [IPROUTE PATCH] iproute2: act_ipt fix xtables breakage on older versions Alexander Duyck
2013-04-25 23:16 ` Stephen Hemminger
2013-04-26 13:20 ` Jamal Hadi Salim
2013-04-26 15:58 ` Alexander Duyck
2013-04-28 14:31 ` Jamal Hadi Salim [this message]
2013-04-28 20:53 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517D32AE.503@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@vyatta$(echo .)com \
--cc=shemonc@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox