From: "Nithin Nayak Sujir" <nsujir@broadcom•com>
To: "Flavio Leitner" <fbl@redhat•com>
Cc: netdev <netdev@vger•kernel.org>, "Jiri Benc" <jbenc@redhat•com>,
"Michael Chan" <mchan@broadcom•com>
Subject: Re: [PATCH net-next] tg3: shows HW time stamping support only if ptp_capable is present
Date: Mon, 29 Apr 2013 11:09:39 -0700 [thread overview]
Message-ID: <517EB763.8090009@broadcom.com> (raw)
In-Reply-To: <1367255287-2664-1-git-send-email-fbl@redhat.com>
On 04/29/2013 10:08 AM, Flavio Leitner wrote:
> Current tg3 shows hardware timestamping support for all devices
> when that is true only for the hardware with PTP_CAPABLE flag
> present.
>
> Signed-off-by: Flavio Leitner <fbl@redhat•com>
> ---
> drivers/net/ethernet/broadcom/tg3.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index ac83c87..ef0b8a6 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -5992,10 +5992,13 @@ static int tg3_get_ts_info(struct net_device *dev, struct ethtool_ts_info *info)
>
> info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE |
> SOF_TIMESTAMPING_RX_SOFTWARE |
> - SOF_TIMESTAMPING_SOFTWARE |
> - SOF_TIMESTAMPING_TX_HARDWARE |
> - SOF_TIMESTAMPING_RX_HARDWARE |
> - SOF_TIMESTAMPING_RAW_HARDWARE;
> + SOF_TIMESTAMPING_SOFTWARE;
> +
> + if (tg3_flag(tp, PTP_CAPABLE)) {
> + info->so_timestamping = SOF_TIMESTAMPING_TX_HARDWARE |
> + SOF_TIMESTAMPING_RX_HARDWARE |
> + SOF_TIMESTAMPING_RAW_HARDWARE;
> + }
>
> if (tp->ptp_clock)
> info->phc_index = ptp_clock_index(tp->ptp_clock);
>
Thanks Flavio.
Acked-by: Nithin Nayak Sujir <nsujir@broadcom•com>
next prev parent reply other threads:[~2013-04-29 18:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 17:08 [PATCH net-next] tg3: shows HW time stamping support only if ptp_capable is present Flavio Leitner
2013-04-29 18:09 ` Nithin Nayak Sujir [this message]
2013-04-29 19:16 ` David Miller
2013-04-30 8:50 ` Jiri Benc
2013-04-30 13:10 ` Flavio Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517EB763.8090009@broadcom.com \
--to=nsujir@broadcom$(echo .)com \
--cc=fbl@redhat$(echo .)com \
--cc=jbenc@redhat$(echo .)com \
--cc=mchan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox