From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Vipul Pandya <vipul@chelsio•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net, divy@chelsio•com,
dm@chelsio•com, abhishek@chelsio•com, leedom@chelsio•com,
swise@opengridcomputing•com
Subject: Re: [PATCH net 3/3] cxgb4vf: Support CPL_SGE_EGR_UPDATEs encapsulated in a CPL_FW4_MSG
Date: Mon, 29 Apr 2013 22:55:43 +0400 [thread overview]
Message-ID: <517EC22F.9020102@cogentembedded.com> (raw)
In-Reply-To: <1367244281-23043-4-git-send-email-vipul@chelsio.com>
Hello.
On 04/29/2013 06:04 PM, Vipul Pandya wrote:
> Newer firmware can post CPL_SGE_EGR_UPDATE message encapsulated in a
> CPL_FW4_MSG as follows
>
> flit0 rss_header (if DropRSS == 0 in IQ context)
> flit1 CPL_FW4_MSG cpl
> flit2 rss_header w/opcode CPL_SGE_EGR_UPDATE
> flit3 CPL_SGE_EGR_UPDATE cpl
>
> So FW4_MSG CPLs with a newly created type of FW_TYPE_RSSCPL have the
> CPL_SGE_EGR_UPDATE CPL message in flit 2 of the FW4_MSG. Firmware can still
> post regular CPL_SGE_EGR_UPDATE messages, so the drivers need to handle
> both.
>
> This patch also writes a new parameter to firmware requesting encapsulated
> EGR_UPDATE. This allows firmware with this support to not break older drivers.
>
> Signed-off-by: Vipul Pandya <vipul@chelsio•com>
[...]
> diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
> index 73aef76..40c22e7 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
> @@ -409,6 +409,20 @@ static int fwevtq_handler(struct sge_rspq *rspq, const __be64 *rsp,
> break;
> }
>
> + case CPL_FW4_MSG: {
> + /* FW can send EGR_UPDATEs encapsulated in a CPL_FW4_MSG.
> + */
> + const struct cpl_sge_egr_update *p = (void *)(rsp + 3);
Empty line wouldn't hurt here, after the declaration.
> + opcode = G_CPL_OPCODE(ntohl(p->opcode_qid));
> + if (opcode != CPL_SGE_EGR_UPDATE) {
> + dev_err(adapter->pdev_dev, "unexpected FW4/CPL %#x on FW event queue\n"
> + , opcode);
> + break;
> + }
> + cpl = (void *)p;
> + /*FALLTHROUGH*/
Rather pointless comment at end of *switch*. Adn you forgot to add
spaced before */ and after /*.
> + }
> +
> case CPL_SGE_EGR_UPDATE: {
> /*
> * We've received an Egress Queue Status Update message. We
[...]
WBR, Sergei
next prev parent reply other threads:[~2013-04-29 18:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 14:04 [PATCH net 0/3] Bug fixes for cxgb4 and cxgb4vf Vipul Pandya
2013-04-29 14:04 ` [PATCH net 1/3] cxgb4: Fix pci_device_id structure initialization with correct PF number Vipul Pandya
2013-04-29 14:04 ` [PATCH net 2/3] cxgb4: Support CPL_SGE_EGR_UPDATEs encapsulated in a CPL_FW4_MSG Vipul Pandya
2013-04-29 14:04 ` [PATCH net 3/3] cxgb4vf: " Vipul Pandya
2013-04-29 18:55 ` Sergei Shtylyov [this message]
2013-04-30 6:46 ` Vipul Pandya
2013-04-29 14:49 ` [PATCH net 0/3] Bug fixes for cxgb4 and cxgb4vf Vipul Pandya
2013-04-29 19:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517EC22F.9020102@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=abhishek@chelsio$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=divy@chelsio$(echo .)com \
--cc=dm@chelsio$(echo .)com \
--cc=leedom@chelsio$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=swise@opengridcomputing$(echo .)com \
--cc=vipul@chelsio$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox