Subject: Re: [Patch net-next v7 5/6] vxlan: respect disable_ipv6 sysctl

From: Sergei Shtylyov <[email-masked]>
Date: Tue, 30 Apr 2013 16:27:41 +0400

Hello.

On 30-04-2013 12:43, Cong Wang wrote:

> From: Cong Wang <[email-masked]>

> When disable_ipv6 is set, we should not allow IPv6 vxlan
> device to be created on top of it.

> Cc: David Miller <[email-masked]>
> Signed-off-by: Cong Wang <[email-masked]>
> ---
>   drivers/net/vxlan.c |   12 ++++++++++++
>   1 files changed, 12 insertions(+), 0 deletions(-)

> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index bb39e67..ec1007a 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
[...]
> @@ -1722,6 +1725,15 @@ static int vxlan_newlink(struct net *net, struct net_device *dev,
>   			return -ENODEV;
>   		}
>
> +#if IS_ENABLED(CONFIG_IPV6)
> +		if (use_ipv6) {
> +			struct inet6_dev *idev = in6_dev_get(lowerdev);

    Empty line wouldn't hurt here, after declaration.

> +			if (idev && idev->cnf.disable_ipv6)
> +					return -EPERM;
> +		}
> +#else
> +		BUG_ON(use_ipv6);
> +#endif

WBR, Sergei