From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Alexander Duyck <alexander.h.duyck@intel•com>
Cc: shemminger@vyatta•com, netdev@vger•kernel.org,
jeffrey.t.kirsher@intel•com, Hasan Chowdhury <shemonc@gmail•com>
Subject: Re: [IPROUTE PATCH v2] iproute2: act_ipt fix xtables breakage on older versions.
Date: Wed, 01 May 2013 10:22:06 -0400 [thread overview]
Message-ID: <5181250E.70303@mojatatu.com> (raw)
In-Reply-To: <20130429154644.52016.60284.stgit@ahduyck-cp1.jf.intel.com>
On 13-04-29 11:50 AM, Alexander Duyck wrote:
> In trying to build on a RHEL6.3 I ran into several build issues that are
> addressed in this patch.
>
> The first is that xtables_merge_options only has 3 parameters. It appears
> this is how this code was originally. As such for the case where the version
> is less than 6 I am assuming it would be correct to maintain the original
> setup that only had 3 parameters being passed instead of 4.
>
> I also ran into an issue with the define for __ALIGN_KERNEL not being present.
> I believe this may be due to the fact that __ALIGN_KERNEL was moved into a
> separate header from ALIGN after the UAPI changes. In order to just cover all
> of the bases I have moved the main definition for the macros into
> __ALIGN_KERNEL_MASK and __ALIGN_KERNEL and if ALIGN is also needed then it is
> just a direct redefine to __ALIGN_KERNEL.
>
> Cc: Hasan Chowdhury <shemonc@gmail•com>
> Cc: Jamal Hadi Salim <jhs@mojatatu•com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel•com>
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu•com>
cheers,
jamal
prev parent reply other threads:[~2013-05-01 14:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 15:50 [IPROUTE PATCH v2] iproute2: act_ipt fix xtables breakage on older versions Alexander Duyck
2013-04-30 12:59 ` Jamal Hadi Salim
2013-04-30 16:07 ` Alexander Duyck
2013-05-01 13:47 ` Jamal Hadi Salim
2013-05-01 14:21 ` Jamal Hadi Salim
2013-05-01 17:18 ` Alexander Duyck
2013-05-01 14:22 ` Jamal Hadi Salim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5181250E.70303@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@vyatta$(echo .)com \
--cc=shemonc@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox